Fix top-level examples in push.go. #1298
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the func doc for New(): "However, do not include the “/metrics/jobs/…” part." Signed-off-by: eduarrrd <eduarrrd@users.noreply.github.com>
bwplotka
approved these changes
Jun 19, 2023
| @@ -16,10 +16,10 @@ | |||
| // by using its methods, finally calling Add or Push, like this: | |||
| // | |||
| // // Easy case: | |||
| // push.New("http://example.org/metrics", "my_job").Gatherer(myRegistry).Push() | |||
| // push.New("http://example.org/", "my_job").Gatherer(myRegistry).Push() | |||
There was a problem hiding this comment.
Suggested change
| // push.New("http://example.org/", "my_job").Gatherer(myRegistry).Push() | |
| // push.New("http://pushgateway.example.org", "my_job").Gatherer(myRegistry).Push() |
| // | ||
| // // Complex case: | ||
| // push.New("http://example.org/metrics", "my_job"). | ||
| // push.New("http://example.org/", "my_job"). |
There was a problem hiding this comment.
Suggested change
| // push.New("http://example.org/", "my_job"). | |
| // push.New("http://pushgateway.example.org", "my_job"). |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
|
👋🏽 Moved to draft, since there are some comments to address, but otherwise it would be nice to have this! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the func doc for New(): "However, do not include the “/metrics/jobs/…” part."