Skip to content

Conversation

@ying-jeanne
Copy link
Contributor

@ying-jeanne ying-jeanne commented Oct 12, 2024

Fixes: #1591

Following the instructions in PR #1625, I am merging the WASI and JS process collector implementations into a unified file to reduce code duplication and complete the original ticket.
@bwplotka @ArthurSens @kakkoyun

Signed-off-by: Ying WANG <ying.wang@grafana.com>
@ying-jeanne ying-jeanne marked this pull request as ready for review October 12, 2024 00:03
@ying-jeanne ying-jeanne changed the title process_collector: Merge wasip1 and js into a single implementation process_collector: merge wasip1 and js into a single implementation Oct 12, 2024
Copy link
Member

@bwplotka bwplotka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! Thanks 💪🏽

@bwplotka bwplotka merged commit 9c67f61 into prometheus:main Oct 14, 2024
10 checks passed
amberpixels pushed a commit to amberpixels/prometheus_client_golang that referenced this pull request Nov 29, 2024
…rometheus#1644)

Signed-off-by: Ying WANG <ying.wang@grafana.com>
Signed-off-by: Eugene <eugene@amberpixels.io>
@renovate renovate bot mentioned this pull request Oct 8, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

processcollector: Overhaul processcollector for consistency and testability

2 participants