exp: Add README, address feedback, use sync.Pool #1747
Merged
+400
−135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
saswatamcode
requested review from
ArthurSens,
bwplotka,
kakkoyun and
vesari
as code owners
kakkoyun
approved these changes
Feb 24, 2025
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
saswatamcode
force-pushed
the
remotefollow
branch
from
9ea77b7 to
49fa6d1
Compare
bwplotka
approved these changes
Feb 25, 2025
| @@ -94,6 +94,26 @@ const ( | |||
| writtenExemplarsHeader = "X-Prometheus-Remote-Write-Exemplars-Written" | |||
| ) | |||
|
|
|||
| // WriteResponse represents the response from the remote storage upon receiving a remote write request. | |||
| type WriteResponse struct { | |||
There was a problem hiding this comment.
I think there's room to make this easy to CREATE by creating helpers, methods and removing ability to unnecessary read it.
But we can just place comment "TODO" and do it later, ok to merge without it.
There was a problem hiding this comment.
Ok embedded response stats into the WriteResponse, made all fields private and added some create/setter/getter, and modified Add a bit to make the entire thing a bit cleaner.
Should be easy to construct this now :)
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com>
bwplotka
added a commit
that referenced
this pull request
Feb 25, 2025
…t and handler. (#1658) * api: Add remote API with write client; add remote handler. Signed-off-by: bwplotka <bwplotka@gmail.com> * Make Write message type more flexble, address some feedback (#1710) * Address remaining feedback Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Make Write message type more flexible Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> --------- Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Move remote write API to client_golang/exp (#1711) * Move remote write API to client_golang/exp Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Don't use api.Client structs, add options for middleware Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix reqBuf usage Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Fix url path Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Add separate mod file (and workspace file) Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Hook exp tests fmt; Test handler error case; Configure backoff Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> --------- Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * exp: Add README, address feedback, use sync.Pool (#1747) * Implement suggestion for Store interface and contentType Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Add README Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Use sync.Pool Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Implement review suggestions Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Release bufs right after compressPayload Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> --------- Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> * Bump exp to go 1.22 Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> --------- Signed-off-by: bwplotka <bwplotka@gmail.com> Signed-off-by: Saswata Mukherjee <saswataminsta@yahoo.com> Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com> Co-authored-by: Saswata Mukherjee <saswataminsta@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR,