Explicitly forward metricVec methods Collect, Describe, Reset #714
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interestingly, methods implicitly forwarded from embedded types are detected by GoDoc if they are just one level deep. Embedded types in the embedded type are not recognized. This commit therefore adds explicit forwarding methods for Collect, Describe, and Reset. Signed-off-by: beorn7 <beorn@grafana.com>
roidelapluie
approved these changes
Feb 13, 2020
|
There are plenty of related bugs: golang/go#2971 golang/go#6127 golang/go#6600 … it seems to be a complicated and hairy topic. |
|
Thanks for digging, at least now we have some references. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interestingly, methods implicitly forwarded from embedded types are
detected by GoDoc if they are just one level deep. Methods of embedded types in
the embedded type are not recognized. This commit therefore adds
explicit forwarding methods for Collect, Describe, and Reset.
@bwplotka I discovered that while working on the promauto changes. Please have a look, easy review. (o: