Use buffered writer #1241
Open
Use buffered writer #1241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without buffered reader, every single output character through given stack goes to "StreamEncoder public void write(int c)" and single element char array is created.
It makes pressure to GC and CPU
BufferedReader reduce the pressure
write:130, StreamEncoder (sun.nio.cs)
write:201, OutputStreamWriter (java.io)
writeMetadata:338, PrometheusTextFormatWriter (io.prometheus.metrics.expositionformats)
writeGauge:129, PrometheusTextFormatWriter (io.prometheus.metrics.expositionformats)
write:68, PrometheusTextFormatWriter (io.prometheus.metrics.expositionformats)
write:48, PrometheusOutputFormat$1 (org.springframework.boot.actuate.metrics.export.prometheus)
scrape:87, PrometheusScrapeEndpoint (org.springframework.boot.actuate.metrics.export.prometheus)
StreamEncoder public void write(int c) throws IOException {
char[] cbuf = new char[1];
cbuf[0] = (char) c;
Signed-off-by: Michal Domagala <michaldo@github.io>
michaldo
force-pushed
the
use-buffered-writer
branch
from
b26dd34 to
b9421b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without buffered reader, every single output character through given stack goes to "StreamEncoder public void write(int c)" and single element char array is created. It makes pressure to GC and CPU
In my case 800K char[1] arrays are created and garbage collected
BufferedReader reduce the pressure