Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve shortcomings in the first iteration of CKMS #759

Closed
wants to merge 4 commits into from

Conversation

DieBauer
Copy link
Contributor

@DieBauer DieBauer commented Jan 31, 2022

After discussion in #755 a next iteration:

  • Introduce a dynamic batch size with an upper limit of 500. It looks like smaller batch size gives better results (precision) for single quantiles.
  • Skip merging the first item of the samples, to always have the real value of p0.
  • Enable the quantile to be 0 or 1, and short-circuit the get method to directly get the values for p0 and p100.
  • Fixes a bug that the pXX value was not within error bounds

fstab and others added 4 commits January 30, 2022 21:41
Signed-off-by: Fabian Stäber <fabian@fstab.de>
The last element is always preserved. By skipping the first element in samples, we can also answer the p0 query.

Signed-off-by: Jens <jenskat@gmail.com>
Signed-off-by: Jens <jenskat@gmail.com>
Increase the currentRank variable if an item is inserted

Signed-off-by: Jens <jenskat@gmail.com>
@fstab
Copy link
Member

fstab commented Feb 3, 2022

Fixed with #755.

@fstab fstab closed this Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants