Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed pushgateway.md #1083

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

mallika-mur
Copy link

I tried to make the documentation on the Pushgateway slightly more readable, and added a small note about what the Pushgateway is supposed to do. I'm still quite new to Prometheus, so I hope this will be helpful.

Mallika Muralidharan added 2 commits January 8, 2025 17:22
Signed-off-by: Mallika Muralidharan <mallika.muralidharan@lrz.de>
Signed-off-by: Mallika Muralidharan <mallika.muralidharan@lrz.de>
Mallika Muralidharan added 4 commits January 8, 2025 17:26
Signed-off-by: Mallika Muralidharan <mallika.muralidharan@lrz.de>
Signed-off-by: Mallika Muralidharan <mallika-mur>
Signed-off-by: Mallika Muralidharan <mallika.muralidharan@lrz.de>
Signed-off-by: Mallika Muralidharan <mallika-mur>
Signed-off-by: Mallika Muralidharan <mallika.muralidharan@lrz.de>
@mallika-mur mallika-mur closed this Jan 8, 2025
@mallika-mur mallika-mur reopened this Jan 8, 2025
Copy link
Member

@csmarchbanks csmarchbanks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just one tiny request.

Comment on lines +25 to +28
1. `push_to_gateway` replaces metrics
with the same grouping key
2. `pushadd_to_gateway` only replaces metrics with the
same name and grouping key
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny comment, could you end these two points with a period as well to match 3 and 4?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants