Remove call to deprecated URI.escape
#188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method has been deprecated for a while, and it gives us warnings in Ruby 2.7 Signed-off-by: Daniel Magliola <danielmagliola@gocardless.com>
dmagliola
force-pushed
the
remove_deprecated_escaping
branch
from
2ef952f
to
f31bdcb
Compare
2 similar comments
Sinjo
approved these changes
Jun 28, 2020
There was a problem hiding this comment.
So after our call I went away and did some reading. This post was one of the clearer explanations I found.
It seems that it's hard to find a perfect answer in stdlib, including the one we were already using in URI.escape. There's one in the addressable gem, but I'm loath to drag that in just for this push gateway code when it's not clear that the differences in approach make any practical difference for thus usage.
This change seems like a strict upgrade, so let's go with it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method has been deprecated for a while, and it gives us warnings in Ruby 2.7