Fix Ruby Warnings #191
Merged
Fix Ruby Warnings #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmagliola
commented
May 26, 2020
| @@ -29,16 +29,17 @@ def initialize(name, | |||
| @docstring = docstring | |||
| @preset_labels = stringify_values(preset_labels) | |||
|
|
|||
| @all_labels_preset = false | |||
There was a problem hiding this comment.
warning: instance variable @all_labels_preset not initialized
dmagliola
commented
May 26, 2020
| if preset_labels.keys.length == labels.length | ||
| @validator.validate_labelset!(preset_labels) | ||
| @all_labels_preset = true | ||
| end |
There was a problem hiding this comment.
Moved this block up since it makes sense to have it closer to the other @label variable definitions
dmagliola
commented
May 26, 2020
|
|
||
| v.each_with_object({}) do |(label_set, v), acc| | ||
| values.each_with_object({}) do |(label_set, v), acc| |
There was a problem hiding this comment.
warning: shadowing outer local variable - v
dmagliola
commented
May 26, 2020
|
|
||
| result = v.each_with_object({}) do |(label_set, v), acc| | ||
| result = values.each_with_object({}) do |(label_set, v), acc| |
There was a problem hiding this comment.
warning: shadowing outer local variable - v
dmagliola
commented
May 26, 2020
| actual_label_set = label_set.reject{|l| l == :le } | ||
| acc[actual_label_set] ||= @buckets.map{|b| [b.to_s, 0.0]}.to_h | ||
| acc[actual_label_set][label_set[:le].to_s] = v | ||
| end | ||
|
|
||
| result.each do |(label_set, v)| | ||
| result.each do |(_label_set, v)| |
There was a problem hiding this comment.
warning: assigned but unused variable - label_set
I'm leaving the variable name, instead of setting to just _ to document what params are being passed here
dmagliola
commented
May 26, 2020
| @@ -74,6 +74,7 @@ def initialize(metric_name:, store_settings:, metric_settings:) | |||
| @metric_name = metric_name | |||
| @store_settings = store_settings | |||
| @values_aggregation_mode = metric_settings[:aggregation] | |||
| @store_opened_by_pid = nil | |||
There was a problem hiding this comment.
warning: instance variable @store_opened_by_pid not initialized
Our tests are running without outputting warnings, so we don't see a number of things Ruby was warning us about. All these code changes are effectively a NOOP. Signed-off-by: Daniel Magliola <dmagliola@crystalgears.com>
dmagliola
force-pushed
the
fix_all_labels_preset_warning
branch
from
53259d8
to
db572f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our tests are running without outputting warnings, so we don't see a number
of things Ruby was warning us about.
All these code changes are effectively a NOOP.