Add support for summaries #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends mainly on a new release of the |
| counter.increment(service: 'foo') | ||
|
|
||
| # increment by a given value | ||
| counter.increment({}, 5) |
There was a problem hiding this comment.
Wouldn't it be more clear to include a label specification in this one?
This change adds supports for summaries, which accumlate sample values and return a set of quantile values (0.5, 0.9, 0.99). A couple of changes and cleanup were necessary, as Summaries are more complex values than a simpler counter or gauge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds supports for summaries, which accumlate sample values
and return a set of quantile values (0.5, 0.9, 0.99). A couple of
changes and cleanup were necessary, as Summaries are more complex values
than a simpler counter or gauge.
@porras / @matttproud: Couldn't sleep in the plane, so I went ahead :) You might also want to have a look at the output of the updated included example rack app: https://gist.github.com/grobie/7331513