feat(encoding)!: EncodeLabelSet::encode() uses reference
#257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cratelyn
force-pushed
the
encode-mut-ref.deux-label-set-only
branch
from
1ca988b to
e281ace
Compare
cratelyn
force-pushed
the
encode-mut-ref.deux-label-set-only
branch
from
e281ace to
5d6c169
Compare
mxinden
reviewed
Jan 21, 2025
There was a problem hiding this comment.
Very well done @cratelyn! Thank you.
@olix0r want to give this a review as well? Does this address your issue mentioned in #240 (comment)? Are there any other (breaking) changes you would need for linkerd?
olix0r
approved these changes
Jan 22, 2025
this commit alters the signature of the `EncodeLabelSet::encode()` trait method, such that it now accepts a mutable reference to its encoder. this is related to prometheus#135, and is a second proposal following previous work in prometheus#240. this change permits distinct label sets to be composed together, now that the label set encoder is not consumed. a new implementation for tuples `(A, B)` is provided. this commit includes a test case showing that a metric family can compose two label sets together, and that such a family can successfully be digested by the python client library. `derive-encode` is altered to generate code matching this new trait signature, and has been bumped to version 0.5.0 as a result of this breaking change in the `prometheus-client` library. Signed-off-by: katelyn martin <me+cratelyn@katelyn.world>
cratelyn
force-pushed
the
encode-mut-ref.deux-label-set-only
branch
from
5d6c169 to
98bca72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit alters the signature of the
EncodeLabelSet::encode()trait method, such that it now accepts a mutable reference to its encoder.this is related to #135, and is a second proposal following previous work in #240.
this change permits distinct label sets to be composed together, now that the label set encoder is not consumed. a new implementation for tuples
(A, B)is provided.this commit includes a test case showing that a metric family can compose two label sets together, and that such a family can successfully be digested by the python client library.
derive-encodeis altered to generate code matching this new trait signature, and has been bumped to version 0.5.0 as a result of this breaking change in theprometheus-clientlibrary.