-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ProxyConnectHeader #402
Labels
Comments
mem
added a commit
that referenced
this issue
Nov 11, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: #402 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
that referenced
this issue
Nov 11, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: #402 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
that referenced
this issue
Nov 11, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: #402 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
to grafana/prometheus-common
that referenced
this issue
Nov 11, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: prometheus#402 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
that referenced
this issue
Nov 21, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: #402 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
that referenced
this issue
Dec 1, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: #402 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
that referenced
this issue
Dec 1, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: #402 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
to grafana/prometheus-common
that referenced
this issue
Dec 1, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: prometheus#402 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
to grafana/prometheus-common
that referenced
this issue
Dec 1, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: prometheus#402 Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
that referenced
this issue
Dec 13, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: #402 Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
that referenced
this issue
Dec 13, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: #402 Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
that referenced
this issue
Dec 13, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: #402 Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
mem
added a commit
to grafana/prometheus-common
that referenced
this issue
Dec 13, 2022
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: prometheus#402 Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this issue
May 18, 2023
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: prometheus#402 Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
radek-ryckowski
pushed a commit
to goldmansachs/common
that referenced
this issue
May 30, 2023
Some proxy configurations require additional headers to be able to use them (e.g. authorization token specific to the proxy). Fixes: prometheus#402 Co-authored-by: Julien Pivotto <roidelapluie@o11y.eu> Signed-off-by: Marcelo E. Magallon <marcelo.magallon@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The roundtripper created using NewRoundTripperFromConfig supports proxies, but it doesn't support proxy-specific headers using
ProxyConnectHeader
. This is simply an option that could be passed to the configuration and added to the transport that is created. Going thru the Go code in the standard library, it looks like this only has effect if the connection method isCONNECT
.The text was updated successfully, but these errors were encountered: