expfmt: Add UTF-8 syntax support in text_parse.go #670

fedetorres93 · 2024-07-31T17:27:06Z

This PR adds support for the new UTF-8 syntax proposed here.

Main changes:

Metric names may include UTF-8 characters and, if so, they will be quoted and inside brackets, without an operator (for example: {"my.metric", label="value"} 1)
Label names may include UTF-8 characters and, if so, they will be quoted (for example: {"my.metric", "my.label"="value"} 1)

Addresses #554

Signed-off-by: Federico Torres <federico.torres@grafana.com>

beorn7

Thanks for doing this.

@ywwg mentioning you here in case you haven't seen it. You are probably more qualified to review this than me.

beorn7 · 2024-08-08T11:08:28Z

expfmt/text_parse.go

+ p.parseError(fmt.Sprintf("unexpected end of metric value %q", p.currentByte))
+ return nil
+ }
+ } else {


All code paths in the if clause above end up returning, so we don't need the else here.

beorn7 · 2024-08-08T11:13:43Z

expfmt/text_parse.go

@@ -60,6 +60,7 @@ type TextParser struct {
 currentMF *dto.MetricFamily
 currentMetric *dto.Metric
 currentLabelPair *dto.LabelPair
+ currentLabel []*dto.LabelPair


I know that protobuf uses the singular even for repeated messages. But maybe it would still make more sense and be more readable to use the plural here? currentLabels collides with the map of the same name below, but maybe call this currentLabelPairs? Also, is there a good comment to add here to explain what this variable is for? (cf. the comment for the currentLabels variable below).

beorn7 · 2024-08-08T11:17:28Z

expfmt/text_parse_test.go

@@ -385,6 +385,159 @@ request_duration_microseconds_count 2693
 },
 },
 },
+ // 5: UTF-8 counter


Nit: This should end with a period to be consistent with the naming above.

More substantially: Let's be more explicit here about what's significant. It's not special that this is a counter, and "UTF-8" per se doesn't say anything (the old metric names were all valid UTF-8, too). How about "Quoted metric name and quoted label name with dots."?

beorn7 · 2024-08-08T11:20:09Z

expfmt/text_parse_test.go

+ },
+ },
+ },
+ // 6: Dots in name


Suggestion: "Metric family with dots in name."

beorn7 · 2024-08-08T11:20:35Z

expfmt/text_parse_test.go

+ },
+ },
+ },
+ // 6: Dots in name, no labels


As above, end with period.

beorn7 · 2024-08-08T11:21:24Z

expfmt/text_parse_test.go

+ },
+ },
+ },
+ // 7: Gauge, UTF-8, +Inf as value, multi-byte characters in label values.


As above, "gauge" is not important. Say something about the special character rather than just stating "UTF-8".

beorn7 · 2024-08-08T11:27:44Z

expfmt/text_parse_test.go

+ },
+ },
+ },
+ },


We need more test cases. Ideas:

Various escaped special characters in a label name and a metric name (like \", but also including multi-line with \n).

The name is not the first element: {foo="bar", "late.name"}.

It would be good to also add a few more cases to testTextParseError, e.g. multiple metric names like {"one.name", "another.name"}.

Signed-off-by: Federico Torres <federico.torres@grafana.com>

…utf-8

Signed-off-by: Federico Torres <federico.torres@grafana.com>

fedetorres93 · 2024-08-16T20:50:38Z

@beorn7 Thank you for your review. All feedback has been addressed.

beorn7

LGTM. @ywwg do you want to give it a final look?

ywwg

have you run code coverage on this to make sure the major branches are covered? Unless something is missing, lgtm

Signed-off-by: Federico Torres <federico.torres@grafana.com>

fedetorres93 · 2024-08-20T19:35:40Z

have you run code coverage on this to make sure the major branches are covered? Unless something is missing, lgtm

Most branches were covered, but I added a couple more tests to cover additional error cases.

ywwg

thank you for the last tests! lgtm

beorn7 · 2024-08-21T11:43:04Z

Thank you both. I'll squash this because we have quite a few mini commits in here.

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.56.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@multani](https://togithub.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@ilius](https://togithub.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#664 - Revert [#576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@ywwg](https://togithub.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@dswarbrick](https://togithub.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@fedetorres93](https://togithub.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@ywwg](https://togithub.com/ywwg) in [prometheus/common#682 #### New Contributors - [@multani](https://togithub.com/multani) made their first contribution in [prometheus/common#647 - [@ilius](https://togithub.com/ilius) made their first contribution in [prometheus/common#662 - [@dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/XSAM/otelsql).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.56.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.56.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@multani](https://togithub.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@ilius](https://togithub.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#664 - Revert [#576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@ywwg](https://togithub.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@dswarbrick](https://togithub.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@fedetorres93](https://togithub.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@ywwg](https://togithub.com/ywwg) in [prometheus/common#682 #### New Contributors - [@multani](https://togithub.com/multani) made their first contribution in [prometheus/common#647 - [@ilius](https://togithub.com/ilius) made their first contribution in [prometheus/common#662 - [@dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).  --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

…6059) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.57.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.57.0`](https://togithub.com/prometheus/common/releases/tag/v0.57.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.56.0...v0.57.0) #### What's Changed - feat: new promslog and promslog/flag packages to wrap log/slog by [@tjhop](https://togithub.com/tjhop) in [prometheus/common#677 #### New Contributors - [@tjhop](https://togithub.com/tjhop) made their first contribution in [prometheus/common#677 **Full Changelog**: prometheus/common@v0.56.0...v0.57.0 ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@multani](https://togithub.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@ilius](https://togithub.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#664 - Revert [#576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@ywwg](https://togithub.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@dswarbrick](https://togithub.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@fedetorres93](https://togithub.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@ywwg](https://togithub.com/ywwg) in [prometheus/common#682 #### New Contributors - [@multani](https://togithub.com/multani) made their first contribution in [prometheus/common#647 - [@ilius](https://togithub.com/ilius) made their first contribution in [prometheus/common#662 - [@dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go-contrib).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

…5748) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [github.com/prometheus/common](https://togithub.com/prometheus/common) | `v0.55.0` -> `v0.57.0` | [![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.55.0/v0.57.0?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>prometheus/common (github.com/prometheus/common)</summary> ### [`v0.57.0`](https://togithub.com/prometheus/common/releases/tag/v0.57.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.56.0...v0.57.0) #### What's Changed - feat: new promslog and promslog/flag packages to wrap log/slog by [@tjhop](https://togithub.com/tjhop) in [prometheus/common#677 #### New Contributors - [@tjhop](https://togithub.com/tjhop) made their first contribution in [prometheus/common#677 **Full Changelog**: prometheus/common@v0.56.0...v0.57.0 ### [`v0.56.0`](https://togithub.com/prometheus/common/releases/tag/v0.56.0) [Compare Source](https://togithub.com/prometheus/common/compare/v0.55.0...v0.56.0) #### What's Changed - Don't always fetch a OAuth2 token, if the secret from a file didn't change by [@multani](https://togithub.com/multani) in [prometheus/common#647 - remove dependency to github.com/prometheus/client_golang by [@ilius](https://togithub.com/ilius) in [prometheus/common#662 - Bump github.com/aws/aws-sdk-go from 1.54.7 to 1.54.11 in /sigv4 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#661 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#664 - Revert [#576](https://togithub.com/prometheus/common/issues/576) and add deprecation notice by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/common#665 - Bump golang.org/x/net from 0.26.0 to 0.27.0 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#667 - use basic string in IsValidLegacyMetricName by [@ywwg](https://togithub.com/ywwg) in [prometheus/common#668 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#672 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#674 - Bump github.com/aws/aws-sdk-go from 1.54.19 to 1.55.5 in /sigv4 by [@dependabot](https://togithub.com/dependabot) in [prometheus/common#671 - sigv4: support nil body by [@roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#673 - Fix overflows of untyped int constants on 32-bit by [@dswarbrick](https://togithub.com/dswarbrick) in [prometheus/common#675 - Update client_golang by [@SuperQ](https://togithub.com/SuperQ) in [prometheus/common#676 - Update golangci lint by [@roidelapluie](https://togithub.com/roidelapluie) in [prometheus/common#679 - expfmt: Add UTF-8 syntax support in text_parse.go by [@fedetorres93](https://togithub.com/fedetorres93) in [prometheus/common#670 - Synchronize common files from prometheus/prometheus by [@prombot](https://togithub.com/prombot) in [prometheus/common#681 - fix(utf8): provide a method for explicitly checking label names for legacy validity by [@ywwg](https://togithub.com/ywwg) in [prometheus/common#682 #### New Contributors - [@multani](https://togithub.com/multani) made their first contribution in [prometheus/common#647 - [@ilius](https://togithub.com/ilius) made their first contribution in [prometheus/common#662 - [@dswarbrick](https://togithub.com/dswarbrick) made their first contribution in [prometheus/common#675 - [@fedetorres93](https://togithub.com/fedetorres93) made their first contribution in [prometheus/common#670 **Full Changelog**: prometheus/common@v0.55.0...v0.56.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/open-telemetry/opentelemetry-go).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

fedetorres93 added 7 commits August 1, 2024 11:24

Update expfmt/text_parse.go to support the new UTF-8 syntax

9b8c348

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Fix breaking unit tests

f188861

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Update unit test

dcfa945

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Fix startLabelName stateFn

2fa0278

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Updated unit tests

d2d947d

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Tidy up code

db7d143

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Fix format

5b9fece

Signed-off-by: Federico Torres <federico.torres@grafana.com>

fedetorres93 force-pushed the ftorres/text-parse-utf-8 branch from d5329b2 to 5b9fece Compare August 1, 2024 14:24

Fix imports

076fba3

Signed-off-by: Federico Torres <federico.torres@grafana.com>

fedetorres93 marked this pull request as ready for review August 2, 2024 17:27

beorn7 requested changes Aug 8, 2024

View reviewed changes

ywwg added the priority/P2 label Aug 13, 2024

fedetorres93 added 8 commits August 14, 2024 11:50

Remove unnecessary else statement

ad09b93

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Change currentLabelPairs field name and add descriptive comment

2e984ce

Signed-off-by: Federico Torres <federico.torres@grafana.com>

More explicit test descriptions

58dd08f

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Fix quoted metric and label names reading

52f4fb0

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Add additional text parse test case

91f4f80

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Fix multiple metric names in label set error

6962341

Signed-off-by: Federico Torres <federico.torres@grafana.com>

Merge remote-tracking branch 'upstream/main' into ftorres/text-parse-…

d1f07cd

…utf-8

Add additional text parse error test case

33e2fcc

Signed-off-by: Federico Torres <federico.torres@grafana.com>

fedetorres93 requested a review from beorn7 August 16, 2024 20:47

beorn7 approved these changes Aug 20, 2024

View reviewed changes

ywwg approved these changes Aug 20, 2024

View reviewed changes

Added more test cases

e76d9f5

Signed-off-by: Federico Torres <federico.torres@grafana.com>

ywwg approved these changes Aug 21, 2024

View reviewed changes

beorn7 merged commit 8968b6c into prometheus:main Aug 21, 2024
7 checks passed

fedetorres93 mentioned this pull request Sep 5, 2024

fix(utf8): Fix multiple metric name inside braces validation #691

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

expfmt: Add UTF-8 syntax support in text_parse.go #670

expfmt: Add UTF-8 syntax support in text_parse.go #670

fedetorres93 commented Jul 31, 2024 •

edited

Loading

beorn7 left a comment

beorn7 Aug 8, 2024

beorn7 Aug 8, 2024

beorn7 Aug 8, 2024

beorn7 Aug 8, 2024

beorn7 Aug 8, 2024

beorn7 Aug 8, 2024

beorn7 Aug 8, 2024

fedetorres93 commented Aug 16, 2024

beorn7 left a comment

ywwg left a comment

fedetorres93 commented Aug 20, 2024

ywwg left a comment

beorn7 commented Aug 21, 2024

expfmt: Add UTF-8 syntax support in text_parse.go #670

expfmt: Add UTF-8 syntax support in text_parse.go #670

Conversation

fedetorres93 commented Jul 31, 2024 • edited Loading

beorn7 left a comment

Choose a reason for hiding this comment

beorn7 Aug 8, 2024

Choose a reason for hiding this comment

beorn7 Aug 8, 2024

Choose a reason for hiding this comment

beorn7 Aug 8, 2024

Choose a reason for hiding this comment

beorn7 Aug 8, 2024

Choose a reason for hiding this comment

beorn7 Aug 8, 2024

Choose a reason for hiding this comment

beorn7 Aug 8, 2024

Choose a reason for hiding this comment

beorn7 Aug 8, 2024

Choose a reason for hiding this comment

fedetorres93 commented Aug 16, 2024

beorn7 left a comment

Choose a reason for hiding this comment

ywwg left a comment

Choose a reason for hiding this comment

fedetorres93 commented Aug 20, 2024

ywwg left a comment

Choose a reason for hiding this comment

beorn7 commented Aug 21, 2024

fedetorres93 commented Jul 31, 2024 •

edited

Loading