New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove secret file existence check in Validate for headers #687

Merged

roidelapluie merged 2 commits into prometheus:main from roidelapluie:checkheader

Sep 3, 2024

Member

roidelapluie commented Sep 3, 2024

This commit removes the check for the existence of the secret file for headers in the Validate function. The check is not valid for relative paths since Validate is called before SetDirectory, which is responsible for setting up the environment. This change aligns with the handling of other secret files, which are not checked during config validation.


          Remove secret file existence check in Validate for headers

d64a747

This commit removes the check for the existence of the secret file for
headers in the `Validate` function. The check is not valid for relative
paths since `Validate` is called before `SetDirectory`, which is
responsible for setting up the environment. This change aligns with the
handling of other secret files, which are not checked during config
validation.

Signed-off-by: Julien <roidelapluie@o11y.eu>

roidelapluie force-pushed the checkheader branch from 957e515 to d64a747 Compare

September 3, 2024 08:54

roidelapluie requested a review from SuperQ

September 3, 2024 08:56


          Change the logic for SetDirectory

334963d

Signed-off-by: Julien <roidelapluie@o11y.eu>

Member Author

roidelapluie commented Sep 3, 2024

Added a second commit to align SetDirectory to other configs.

roidelapluie requested review from machine424 and aknuds1

September 3, 2024 09:16

roidelapluie mentioned this pull request

Document custom HTTP headers and add tests prometheus/prometheus#14817

Merged

SuperQ approved these changes

View reviewed changes

roidelapluie merged commit b1880d0 into prometheus:main

7 checks passed

codeboten referenced this pull request in open-telemetry/opentelemetry-collector


          Update module github.com/prometheus/common to v0.59.1 (#11109)

747938b

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/prometheus/common](https://redirect.github.com/prometheus/common)
| `v0.57.0` -> `v0.59.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.59.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.59.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.57.0/v0.59.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.57.0/v0.59.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>prometheus/common (github.com/prometheus/common)</summary>

###
[`v0.59.1`](https://redirect.github.com/prometheus/common/releases/tag/v0.59.1)

[Compare
Source](https://redirect.github.com/prometheus/common/compare/v0.59.0...v0.59.1)

#### What's Changed

- fix(utf8): Fix multiple metric name inside braces validation by
[@&#8203;fedetorres93](https://redirect.github.com/fedetorres93) in
[https://github.com/prometheus/common/pull/691](https://redirect.github.com/prometheus/common/pull/691)

**Full Changelog**:
prometheus/common@v0.59.0...v0.59.1

###
[`v0.59.0`](https://redirect.github.com/prometheus/common/releases/tag/v0.59.0)

[Compare
Source](https://redirect.github.com/prometheus/common/compare/v0.58.0...v0.59.0)

#### What's Changed

- expfmt: Add WithEscapingScheme to help construct Formats by
[@&#8203;ywwg](https://redirect.github.com/ywwg) in
[https://github.com/prometheus/common/pull/688](https://redirect.github.com/prometheus/common/pull/688)
- Change the default escape method to UnderscoreEscaping by
[@&#8203;ywwg](https://redirect.github.com/ywwg) in
[https://github.com/prometheus/common/pull/690](https://redirect.github.com/prometheus/common/pull/690)

**Full Changelog**:
prometheus/common@v0.58.0...v0.59.0

###
[`v0.58.0`](https://redirect.github.com/prometheus/common/releases/tag/v0.58.0)

[Compare
Source](https://redirect.github.com/prometheus/common/compare/v0.57.0...v0.58.0)

#### What's Changed

- docs: mention new promslog package in package list in README by
[@&#8203;tjhop](https://redirect.github.com/tjhop) in
[https://github.com/prometheus/common/pull/683](https://redirect.github.com/prometheus/common/pull/683)
- Bump golang.org/x/oauth2 from 0.21.0 to 0.22.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/prometheus/common/pull/684](https://redirect.github.com/prometheus/common/pull/684)
- Bump golang.org/x/net from 0.27.0 to 0.28.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/prometheus/common/pull/685](https://redirect.github.com/prometheus/common/pull/685)
- Remove secret file existence check in Validate for headers by
[@&#8203;roidelapluie](https://redirect.github.com/roidelapluie) in
[https://github.com/prometheus/common/pull/687](https://redirect.github.com/prometheus/common/pull/687)

**Full Changelog**:
prometheus/common@v0.57.0...v0.58.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>
Co-authored-by: Alex Boten <223565+codeboten@users.noreply.github.com>

mx-psi referenced this pull request in open-telemetry/opentelemetry-collector-contrib


          fix(deps): update module github.com/prometheus/common to v0.59.1 (#35112

942ce30

)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
|
[github.com/prometheus/common](https://redirect.github.com/prometheus/common)
| `v0.57.0` -> `v0.59.1` |
[![age](https://developer.mend.io/api/mc/badges/age/go/github.com%2fprometheus%2fcommon/v0.59.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/go/github.com%2fprometheus%2fcommon/v0.59.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/go/github.com%2fprometheus%2fcommon/v0.57.0/v0.59.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/go/github.com%2fprometheus%2fcommon/v0.57.0/v0.59.1?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>prometheus/common (github.com/prometheus/common)</summary>

###
[`v0.59.1`](https://redirect.github.com/prometheus/common/releases/tag/v0.59.1)

[Compare
Source](https://redirect.github.com/prometheus/common/compare/v0.59.0...v0.59.1)

#### What's Changed

- fix(utf8): Fix multiple metric name inside braces validation by
[@&#8203;fedetorres93](https://redirect.github.com/fedetorres93) in
[https://github.com/prometheus/common/pull/691](https://redirect.github.com/prometheus/common/pull/691)

**Full Changelog**:
prometheus/common@v0.59.0...v0.59.1

###
[`v0.59.0`](https://redirect.github.com/prometheus/common/releases/tag/v0.59.0)

[Compare
Source](https://redirect.github.com/prometheus/common/compare/v0.58.0...v0.59.0)

#### What's Changed

- expfmt: Add WithEscapingScheme to help construct Formats by
[@&#8203;ywwg](https://redirect.github.com/ywwg) in
[https://github.com/prometheus/common/pull/688](https://redirect.github.com/prometheus/common/pull/688)
- Change the default escape method to UnderscoreEscaping by
[@&#8203;ywwg](https://redirect.github.com/ywwg) in
[https://github.com/prometheus/common/pull/690](https://redirect.github.com/prometheus/common/pull/690)

**Full Changelog**:
prometheus/common@v0.58.0...v0.59.0

###
[`v0.58.0`](https://redirect.github.com/prometheus/common/releases/tag/v0.58.0)

[Compare
Source](https://redirect.github.com/prometheus/common/compare/v0.57.0...v0.58.0)

#### What's Changed

- docs: mention new promslog package in package list in README by
[@&#8203;tjhop](https://redirect.github.com/tjhop) in
[https://github.com/prometheus/common/pull/683](https://redirect.github.com/prometheus/common/pull/683)
- Bump golang.org/x/oauth2 from 0.21.0 to 0.22.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/prometheus/common/pull/684](https://redirect.github.com/prometheus/common/pull/684)
- Bump golang.org/x/net from 0.27.0 to 0.28.0 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[https://github.com/prometheus/common/pull/685](https://redirect.github.com/prometheus/common/pull/685)
- Remove secret file existence check in Validate for headers by
[@&#8203;roidelapluie](https://redirect.github.com/roidelapluie) in
[https://github.com/prometheus/common/pull/687](https://redirect.github.com/prometheus/common/pull/687)

**Full Changelog**:
prometheus/common@v0.57.0...v0.58.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "on tuesday" (UTC), Automerge - At any
time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/open-telemetry/opentelemetry-collector-contrib).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIiwicmVub3ZhdGVib3QiXX0=-->

---------

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: opentelemetrybot <107717825+opentelemetrybot@users.noreply.github.com>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet