Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable metric suffixing in OTel PRW exporter to pass compliance tests #106

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

dashpole
Copy link
Contributor

Fixes open-telemetry/opentelemetry-collector-contrib#35119

The counter was being renamed to counter_total. Disable suffixing so that we pass the compliance test.

Signed-off-by: David Ashpole <dashpole@google.com>
Copy link
Member

@ArthurSens ArthurSens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@ArthurSens ArthurSens merged commit ded49e5 into prometheus:main Sep 20, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Prometheus Compliance Tests] TestRemoteWrite/otelcollector/Counter failed on main
2 participants