-
Notifications
You must be signed in to change notification settings - Fork 50
Add remote write 2 receivers compliance tests #182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
cc @bwplotka FYI, WIP |
52cc74d to
43c8e3e
Compare
bwplotka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! I think you gave us some ideas how to improve sender compliance (it tests too much IMO - it's literally scrape+export+Prometheus job/instance/staleness semantics, WDYT?)
What's your experience with the 2.0 protocol? Any feedback before we make it stable?
cc @pipiland2612 do you mind reviewing as well? (:
krajorama
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice indeed.
I understand it's not fully finished, my list of items needed:
- exemplars
- created timestamp
- different order of protobuf fields - this might be tricky, but for example I think Mimir right now would fail if the symbols table is after the timeseries
I think testing RW1 is really difficult because of the lack of headers, out of necessity it is required to also test that the remote is an actual remote.
My main experience is that there is quite a few blind spots in the doc. e.g.: |
|
Pushed an update. Results on cortex, mimir, prometheus: |
|
Looks amazing! I'm encouraging @pipiland2612 to integrate and perhaps reuse index html table |
Ups, will check, looks like a bug, thanks! |
03344a0 to
201d5db
Compare
0e23f12 to
877727b
Compare
Signed-off-by: Julien Pivotto <291750+roidelapluie@users.noreply.github.com>
877727b to
f7ecd7c
Compare
|
Ready for review :-) |
|
Last test run: https://roidelapluie.github.io/rwreport/ |
bwplotka
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
BTW @roidelapluie I checked your feedback around:
I think the current form makes sense. It's MAY and no proto param means v1 for compatibility. That's why it's MAY. Does it make sense? |
No description provided.