Always get the latest version of targets #28
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwilkie
reviewed
May 13, 2021
| const grafanaAgentDownloadURL = "https://github.com/grafana/agent/releases/download/v0.13.1/agent-{{.OS}}-{{.Arch}}.zip" | ||
| func getGrafanaDownloadURL() string { | ||
| version := latest.GetLatestVersion("grafana/agent") | ||
| return "https://github.com/grafana/agent/releases/download/" + version + "/agent-{{.OS}}-{{.Arch}}.zip" |
There was a problem hiding this comment.
Perhaps we could make version a field in the URL template and have downloadBinary extract the github project, lookup the latest version and sub it in?
There was a problem hiding this comment.
I couldn't make it work with templates, but regexp does the job.
RichiH
force-pushed
the
richih/lastest_version
branch
from
9e4261a to
8e83a43
Compare
Signed-off-by: Richard Hartmann <richih@richih.org>
RichiH
force-pushed
the
richih/lastest_version
branch
from
8e83a43 to
07a813a
Compare
If you hammer GH API without a login too often, you will get rate limited over time. As local binaries remain on disk, this should not be too much of a concern. Signed-off-by: Richard Hartmann <richih@richih.org>
RichiH
force-pushed
the
richih/lastest_version
branch
from
91abb5d to
f9371b8
Compare
|
GH API limits are too restrictive, I will need to solve this before we can merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.