Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hints #190

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Add hints #190

merged 1 commit into from
Dec 19, 2023

Conversation

lucacome
Copy link
Contributor

Adds hints for completion.

SuperQ
SuperQ reviewed Dec 19, 2023
View reviewed changes
web/kingpinflag/flag.go Outdated Show resolved Hide resolved
@lucacome
Add hints
32eb795 
Signed-off-by: Luca Comellini <luca.com@gmail.com>
SuperQ
SuperQ approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@SuperQ SuperQ merged commit da3e658 into prometheus:master Dec 19, 2023
5 checks passed
@lucacome lucacome deleted the hint-options branch December 19, 2023 20:23
SuperQ added a commit that referenced this pull request Sep 1, 2024
@SuperQ
Release v0.12.0
d00760b 
* [FEATURE] Add pprof links to landing page #196
* [FEATURE] Support listen on vsock #220
* [ENHANCEMENT] Add hints for bash completion #190
* [ENHANCEMENT] Support kingpin.CmdClause as argument #238
* [BUGFIX] Don't swollow listen errors #232

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Sep 1, 2024
Merged
SuperQ added a commit that referenced this pull request Sep 3, 2024
@SuperQ
Release v0.12.0 (#246)
e078b1f 
* [FEATURE] Add pprof links to landing page #196
* [FEATURE] Support listen on vsock #220
* [ENHANCEMENT] Add hints for bash completion #190
* [ENHANCEMENT] Support kingpin.CmdClause as argument #238
* [BUGFIX] Don't swollow listen errors #232

Signed-off-by: SuperQ <superq@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucacome @SuperQ