Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support listen on vsock #220

Merged
merged 2 commits into from
Aug 2, 2024
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update web/kingpinflag/flag.go
Co-authored-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Leonid Podolny <leonid@podolny.net>
Leonid99 and SuperQ authored Aug 2, 2024
commit 34f112d524c16ebdd09cd382544f4d4d85e4549c
2 changes: 1 addition & 1 deletion web/kingpinflag/flag.go
Original file line number Diff line number Diff line change
@@ -33,7 +33,7 @@ func AddFlags(a *kingpin.Application, defaultAddress string) *web.FlagConfig {
flags := web.FlagConfig{
WebListenAddresses: a.Flag(
"web.listen-address",
"Addresses on which to expose metrics and web interface. Repeatable for multiple addresses. Examples: `:9100` or `127.0.0.1:9100` for http, `vsock://:9100` for vsock",
"Addresses on which to expose metrics and web interface. Repeatable for multiple addresses. Examples: `:9100` or `[::1]:9100` for http, `vsock://:9100` for vsock",
).Default(defaultAddress).HintOptions(defaultAddress).Strings(),
WebSystemdSocket: systemdSocket,
WebConfigFile: a.Flag(

Unchanged files with check annotations Beta

errcheck:
exclude-functions:
# Used in HTTP handlers, any error is handled by the server itself.
- (net/http.ResponseWriter).Write

Check failure on line 17 in .golangci.yml

GitHub Actions / Analyze (go)

17:7 [indentation] wrong indentation: expected 4 but found 6
# Never check for logger errors.
- (github.com/go-kit/log.Logger).Log
revive:
rules:
# https://github.com/mgechev/revive/blob/master/RULES_DESCRIPTIONS.md#unused-parameter
- name: unused-parameter

Check failure on line 23 in .golangci.yml

GitHub Actions / Analyze (go)

23:7 [indentation] wrong indentation: expected 4 but found 6
severity: warning
disabled: true
client_auth_type: "RequireAndVerifyClientCert"
client_ca_file: "client2_selfsigned.pem"
client_allowed_sans:
- "one"

Check failure on line 7 in web/testdata/web_config_auth_client_san.good.yaml

GitHub Actions / Analyze (go)

7:6 [indentation] wrong indentation: expected 4 but found 5
- "test3"
- "two"