Bump Go version #85
Bump Go version #85
Conversation
Signed-off-by: prombot <prometheus-team@googlegroups.com>
Signed-off-by: Simon Pasquier <spasquie@redhat.com>
|
LGTM |
|
As someone pointed out, there's some weird bugs with 1.14 and Linux kernel version checking. We might want to hold off until golang/go#37436 is resolved. |
|
Agreed. |
|
At this stage, I'd like to keep 1.13 for the new release. It is also not clear what the effects of ' A consequence of the implementation of preemption is that on Unix systems, including Linux and macOS systems, programs built with Go 1.14 will receive more signals than programs built with earlier releases. This means that programs that use packages like syscall or golang.org/x/sys/unix will see more slow system calls fail with EINTR errors. Those programs will have to handle those errors in some way, most likely looping to try the system call again. For more information about this see man 7 signal for Linux systems or similar documentation for other systems. " can be. |
|
Note that projects wouldn't automatically switch to 1.14 even if this PR is merged (see prometheus/.promu.yml for instance). |
|
That is interesting. So does it make sense to block this PR? |
|
From what I understood from golang/go#37436, 1.14 just highlights the kernel bug instead of silently failing and does not necessarily introduce that bug. So I am not sure why we are blocked on this upgrade. https://github.com/golang/go/wiki/LinuxKernelSignalVectorBug |
|
We could merge the PR but IIUC it's probably better to wait for Go 1.14.1 before switching projects to Go 1.14 as it would be easier for users to understand what happens. |
|
My point was to merge without updating the projects; to get the build docker image. |
|
@roidelapluie no problem, it was my understanding too. Decision deferred to @SuperQ and @sdurrheimer :) |
|
1.14.1 is out |
|
I bumped this to 1.14.1 |
Signed-off-by: Ben Kochie <superq@gmail.com>
|
Thanks all! |
No description provided.