Fix NullPointerException during scrape (#892)

Signed-off-by: Simon Greatrix <simon.greatrix@setl.io>
prometheus · Nov 15, 2023 · dcd05a3 · dcd05a3
1 parent 89275ac
commit dcd05a3
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/collector/src/main/java/io/prometheus/jmx/JmxScraper.java b/collector/src/main/java/io/prometheus/jmx/JmxScraper.java
@@ -213,6 +213,7 @@ private void scrapeBean(MBeanServerConnection beanConn, ObjectName mBeanName) {
         }
 
         for (Object object : attributes) {
+            // The contents of an AttributeList should all be Attribute instances, but we'll verify that.
             if (object instanceof Attribute) {
                 Attribute attribute = (Attribute) object;
                 String attributeName = attribute.getName();
@@ -241,6 +242,11 @@ private void scrapeBean(MBeanServerConnection beanConn, ObjectName mBeanName) {
                         mBeanAttributeInfo.getType(),
                         mBeanAttributeInfo.getDescription(),
                         attribute.getValue());
+            } else if (object == null) {
+                LOGGER.log(
+                        FINE,
+                        "%s object is NULL, not an instance javax.management.Attribute, skipping",
+                        mBeanName);
             } else {
                 LOGGER.log(
                         FINE,