issue-695: revert bulk loading of attributes #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Angela Stempfel <angela.stempfel@postfinance.ch>
faenschi
force-pushed
the
fix-attribute-loading
branch
from
8a28d70 to
25c148a
Compare
fstab
requested changes
May 9, 2022
There was a problem hiding this comment.
Thanks a lot for the PR. I read the old comments in #238 when we switched from loading individual attributes to bulk loading. It seems like this resulted in a significant performance improvement.
So I'm wondering: Can we keep the bulk loading as default, but revert to attribute-by-attribute loading when an Exception is thrown?
Interestingly that's exactly what was in the original proposal in #238 but it was replaced with "just log the failure and continue".
Signed-off-by: Fabian Stäber <fabian@fstab.de>
|
Hi, I changed the code so that 1-by-1 loading of attributes is only used as a fallback if bulk loading fails. I'm planning to include this in the next release. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fstab closes #695