Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export direct_reclaims_total metric to prometheus #227

Merged
merged 4 commits into from
Nov 8, 2024
Merged

Export direct_reclaims_total metric to prometheus #227

merged 4 commits into from
Nov 8, 2024
+11 −0

Conversation

Vandit1604
Copy link
Contributor

fixes #136

@Vandit1604
add direct_reclaim metric
b6ed409 
Signed-off-by: Vandit Singh <vanditsinghkv@gmail.com>
SuperQ
SuperQ requested changes Sep 1, 2024
View reviewed changes
pkg/exporter/exporter.go Outdated Show resolved Hide resolved
@Vandit1604 @SuperQ
Update pkg/exporter/exporter.go
5b10c07 
Co-authored-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Vandit Singh <107131545+Vandit1604@users.noreply.github.com>
@Vandit1604 Vandit1604 changed the title Export total_direct_reclaim metric to prometheus Export direct_reclaims_total metric to prometheus Sep 2, 2024
@Vandit1604
Copy link
Contributor Author

@SuperQ Is there anything else that needs to be done here to complete the PR?

SuperQ
SuperQ reviewed Oct 17, 2024
View reviewed changes
README.md Outdated
Comment on lines 48 to 49
# HELP memcached_total_direct_reclaims Times worker threads had to directly reclaim or evict items.
# TYPE memcached_total_direct_reclaims counter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also needs to be updated.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Vandit1604 and others added 2 commits October 18, 2024 00:48
@matthiasr matthiasr requested a review from SuperQ November 8, 2024 14:06
@matthiasr matthiasr merged commit 53924a2 into prometheus:master Nov 8, 2024
4 checks passed
@Vandit1604 Vandit1604 deleted the feat/export-direct-reclaims-metric-to-prometheus branch November 8, 2024 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sticksman Sticksman Sticksman approved these changes

@SuperQ SuperQ SuperQ approved these changes

@matthiasr matthiasr matthiasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Export "direct_reclaims"
4 participants
@Vandit1604 @matthiasr @SuperQ @Sticksman