node-mixins/config: Switch fsAvailable warning and critical thresholds #2373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: In 0b50eb7 the usage of the threshold variables was adjusted. The values had been switched as well resulting in reversed thresholds after the commit above. Warnings now have a smaller threshold than critical alerts. Solution: Adjust thresholds to reflect that warnings should be alerted on before critical alerts. Issues: prometheus#2352 Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
|
cc @danlenar |
discordianfish
approved these changes
Jun 7, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: In 0b50eb7 the usage of the
threshold variables was adjusted. The values had been switched as well
resulting in reversed thresholds after the commit above. Warnings now
have a smaller threshold than critical alerts.
Solution: Adjust thresholds to reflect that warnings should be alerted
on before critical alerts.
Issues: #2352
Signed-off-by: Jan Fajerski jfajersk@redhat.com