Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MOD: surface filesystem device error #2918 #2922

Conversation

PamelaMei-SAP
Copy link
Contributor

To provide contribution on issue: #2918

Adding new label of "device_error" to surface error in node_filesystem_device_error.
Tests have been done for below scenarios, could you please help review and share your suggestion? Thanks.

Scenario-1: No device error
curl http://localhost:9100/metrics | grep node_filesystem_device_error | grep 100.70.222.247 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 83276 0 83276 0 0 1786k 0 --:--:-- --:--:-- --:--:-- 1807k node_filesystem_device_error{device="100.70.222.247:/share_5618cf05_5d99_44b6_a90d_8c2797929dbb",device_error="",fstype="nfs4",mountpoint="/test_nfs"} 0

Scenario-2: mountpoint timeout
curl http://localhost:9100/metrics | grep node_filesystem_device_error | grep 100.70.222.247 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 83312 0 83312 0 0 3053k 0 --:--:-- --:--:-- --:--:-- 3129k node_filesystem_device_error{device="100.70.222.247:/share_5618cf05_5d99_44b6_a90d_8c2797929dbb",device_error="mountpoint timeout",fstype="nfs4",mountpoint="/test_nfs"} 1

Scenario-3: error from statfs() e.g. permission denied
curl http://localhost:9100/metrics | grep node_filesystem_device_error | grep 100.70.222.247 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 83208 0 83208 0 0 2943k 0 --:--:-- --:--:-- --:--:-- 3009k node_filesystem_device_error{device="100.70.222.247:/share_5618cf05_5d99_44b6_a90d_8c2797929dbb",device_error="permission denied",fstype="nfs4",mountpoint="/test_nfs"} 1

Signed-off-by: Pamela Mei i540369 <pamela.mei@sap.com>
@PamelaMei-SAP PamelaMei-SAP force-pushed the surface_filesystem_device_error_#2918 branch from d846fdf to a70b5e3 Compare February 11, 2024 02:50
@PamelaMei-SAP
Copy link
Contributor Author

circleci failed in gofmt, re-submit later.

@PamelaMei-SAP PamelaMei-SAP deleted the surface_filesystem_device_error_#2918 branch February 11, 2024 03:05
@SuperQ
Copy link
Member

SuperQ commented Feb 12, 2024

Please do not open and close PRs like this. It spams out system.

You do not need to create new PRs to update the commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants