MOD: surface filesystem device error #2918 #2922
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide contribution on issue: #2918
Adding new label of "device_error" to surface error in node_filesystem_device_error.
Tests have been done for below scenarios, could you please help review and share your suggestion? Thanks.
Scenario-1: No device error
curl http://localhost:9100/metrics | grep node_filesystem_device_error | grep 100.70.222.247 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 83276 0 83276 0 0 1786k 0 --:--:-- --:--:-- --:--:-- 1807k node_filesystem_device_error{device="100.70.222.247:/share_5618cf05_5d99_44b6_a90d_8c2797929dbb",device_error="",fstype="nfs4",mountpoint="/test_nfs"} 0
Scenario-2: mountpoint timeout
curl http://localhost:9100/metrics | grep node_filesystem_device_error | grep 100.70.222.247 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 83312 0 83312 0 0 3053k 0 --:--:-- --:--:-- --:--:-- 3129k node_filesystem_device_error{device="100.70.222.247:/share_5618cf05_5d99_44b6_a90d_8c2797929dbb",device_error="mountpoint timeout",fstype="nfs4",mountpoint="/test_nfs"} 1
Scenario-3: error from statfs() e.g. permission denied
curl http://localhost:9100/metrics | grep node_filesystem_device_error | grep 100.70.222.247 % Total % Received % Xferd Average Speed Time Time Time Current Dload Upload Total Spent Left Speed 100 83208 0 83208 0 0 2943k 0 --:--:-- --:--:-- --:--:-- 3009k node_filesystem_device_error{device="100.70.222.247:/share_5618cf05_5d99_44b6_a90d_8c2797929dbb",device_error="permission denied",fstype="nfs4",mountpoint="/test_nfs"} 1