Split out guest cpu metrics on Linux. #744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperQ
force-pushed
the
superq/guest_cpu
branch
from
ae02cfb to
6f62107
Compare
|
Oh! Good catch. LGTM |
collector/cpu_linux.go
Outdated
| @@ -57,6 +58,11 @@ func NewCPUCollector() (Collector, error) { | |||
| "Seconds the cpus spent in each mode.", | |||
| []string{"cpu", "mode"}, nil, | |||
| ), | |||
| cpuGuest: prometheus.NewDesc( | |||
| prometheus.BuildFQName(namespace, cpuCollectorSubsystem, "guest_seconds_total"), | |||
| "Seconds the cpus spent for guests (VMs) in each mode.", | |||
There was a problem hiding this comment.
The above metric uses "in" rather than "for"
There was a problem hiding this comment.
How about: Seconds the cpus spent in guests (VMs) for each mode.
|
Oh |
Linux "guest" metrics for VMs are already accounted for in node_cpu `user` and `nice` metrics. Separate these into their own metric to avoid duplication of data.
SuperQ
force-pushed
the
superq/guest_cpu
branch
from
6f62107 to
6a1d29e
Compare
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
Linux "guest" metrics for VMs are already accounted for in node_cpu `user` and `nice` metrics. Separate these into their own metric to avoid duplication of data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linux "guest" metrics for VMs are already accounted for in node_cpu
userandnicemetrics. Separate these into their own metric toavoid duplication of data.
Closes: #737