netdev: Change valueType to CounterValue #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We should also fix the metric names to end in |
|
Have you validated that netdev_(bsd|darwin|openbsd) are also all proper counters? I'm guessing they are, but it would be good to validate this assumption if we can. |
Oh, forgot that.. Will do when I get home.
I haven't, but looking through all the naming I won't expect them to decrease. |
All the metric only goes up, so the type should be counter. This also add _total to all the metric name. Fix: #747
Done.. |
|
Great, LGTM! |
oblitorum
pushed a commit
to shatteredsilicon/node_exporter
that referenced
this pull request
Apr 9, 2024
All the metric only goes up, so the type should be counter. This also add _total to all the metric name. Fix: prometheus#747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the metric only goes up, so the type should be counter.
Fix: #747