-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add processes exporter #950
Conversation
Test is failing with |
Yes, i see this, trying to figure out why it fails
@SuperQ is that circle-ci issue? because i can see all stages build successfully on in this particular case it failed unit-tests on 32bit arch, but it there were a problem build would fail as well. |
When I run the test locally, I get different values for the overflow on every run. It looks like you need to init the fixtures Like in ipvs_linux_test.go |
It looks like the path is wrong for the They need to go in |
@SuperQ thanks, i found this out 😄 has no committed yet, my mistake, got distracted and put it to wrong place |
fd2313b
to
707860c
Compare
Something is a little strange with the commits here. But the final diff looks OK. Not sure what is up with DCO not reporting. |
@pkutishch, maybe if you give me access to your fork, I can poke around the git commit history? |
The 3rd commit is a merge commit, and thus lacks the DCO. I'd suggest squashing. |
Signed-off-by: Pavel Kutishchev <pavel.kutishchev@olx.com> Signed-off-by: Ben Kochie <superq@gmail.com>
Ok, I squashed up the commits. Let's see if that makes the DCO bot happy. |
Signed-off-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Ben Kochie <superq@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@brian-brazil Even after rebase, the DCO bot seems stuck on this PR. And there's no debug link for it. |
@SuperQ Thanks for your help! |
Ping, @discordianfish, do you have any additional comments? |
LGTM, thanks! |
I realise this has already been merged, and I welcome its inclusion, but doesn't it sort of make |
@dswarbrick Those come from |
* Add processes exporter Signed-off-by: Pavel Kutishchev <pavel.kutishchev@olx.com> Signed-off-by: Ben Kochie <superq@gmail.com>
Signed-off-by: Pavel Kutishchev pavel.kutishchev@olx.com