Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetRaplZones fails with zone names of the form package-N-die-M #459

Closed
tomhughes opened this issue Jul 9, 2022 · 2 comments
Closed

GetRaplZones fails with zone names of the form package-N-die-M #459

tomhughes opened this issue Jul 9, 2022 · 2 comments

Comments

@tomhughes
Copy link

tomhughes commented Jul 9, 2022

I have a machine which, since a recent kernel upgrade, has rapl zones with names like package-0-die-0 and package-0-die-3 which confuse GetRaplZones as the name parsing at

func getIndexAndName(countNameUsages map[string]int, name string) (int, string) {
tries to parse 0-die-0 as a number and fails, leading to the whole thing being returned as the name.

In turn that leads to node_collector crashing due an invalid metric name of node_rapl_package-0-die-0_joules_total.

@SuperQ
Copy link
Member

SuperQ commented Jul 9, 2022

This is actually a bug in the node_exporter, not the library.

prometheus/node_exporter#2299

@SuperQ SuperQ closed this as completed Jul 9, 2022
@tomhughes
Copy link
Author

Ah apologies for that. I had actually started with the code when trying to figure this out but didn't realise it included unreleased fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants