rapl collector crash: panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name #2299

baryluk · 2022-03-01T09:55:08Z

Host operating system: output of `uname -a`

Linux xyz 4.18.0-358.el8.x86_64 #1 SMP Mon Jan 10 13:11:20 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

node_exporter version: output of `node_exporter --version`

node_exporter, version 1.3.1 (branch: tarball, revision: 4.el8)
  build user:       
  build date:       20220128
  go version:       go1.16.12
  platform:         linux/amd64

node_exporter command line flags

Are you running node_exporter in Docker?

no

What did you do that produced an error?

Running on bare metal on AMD EPYC 7401P 24-Core Processor

After upgrade of the OS, kernel and node exporter, we are getting this:

panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name
goroutine 82 [running]:
panic(0x55f3e1a19920, 0xc0006260e0)
/usr/lib/golang/src/runtime/panic.go:1065 +0x565 fp=0xc00052ac80 sp=0xc00052abb8 pc=0x55f3e0ed72e5
github.com/prometheus/client_golang/prometheus.MustNewConstMetric(...)
/builddir/build/BUILD/node_exporter-1.3.1/vendor/github.com/prometheus/client_golang/prometheus/value.go:107
github.com/prometheus/node_exporter/collector.(*raplCollector).Update(0xc0002b4f20, 0xc0001138c0, 0x55f3e1f16fa0, 0x0)
/builddir/build/BUILD/node_exporter-1.3.1/collector/rapl_linux.go:88 +0xbf7 fp=0xc00052ae10 sp=0xc00052ac80 pc=0x55f3e154aeb7
github.com/prometheus/node_exporter/collector.execute(0x55f3e1582074, 0x4, 0x55f3e1b15408, 0xc0002b4f20, 0xc0001138c0, 0x55f3e1b14c08, 0xc0002ba500)
/builddir/build/BUILD/node_exporter-1.3.1/collector/collector.go:161 +0x86 fp=0xc00052af50 sp=0xc00052ae10 pc=0x55f3e14ee5e6
github.com/prometheus/node_exporter/collector.NodeCollector.Collect.func1(0xc0001138c0, 0xc000289c20, 0x55f3e1b14c08, 0xc0002ba500, 0xc00039eb30, 0x55f3e1582074, 0x4, 0x55f3e1b15408, 0xc0002b4f20)
/builddir/build/BUILD/node_exporter-1.3.1/collector/collector.go:152 +0x6f fp=0xc00052af98 sp=0xc00052af50 pc=0x55f3e156e3af
runtime.goexit()
....

The text was updated successfully, but these errors were encountered:

discordianfish · 2022-03-01T10:10:43Z

@baryluk Thanks for the report. Looks like we need to sanitize the name by wrapping rz.Name here:

node_exporter/collector/rapl_linux.go

Line 83 in 2b490d6

prometheus.BuildFQName(namespace, "rapl", rz.Name+"_joules_total"),

in SanitizeMetricName(). Want to take a stab at this?

baryluk · 2022-03-01T12:29:25Z

Yes. No problem, i will check the test framework for it first.

…

On Tue, 1 Mar 2022, 11:10 discordianfish, ***@***.***> wrote: @baryluk <https://github.com/baryluk> Thanks for the report. Looks like we need to sanitize the name by wrapping rz.Name here: https://github.com/prometheus/node_exporter/blob/2b490d645e0e9773b644dfc3e3313e79eb565b27/collector/rapl_linux.go#L83 in SanitizeMetricName(). Want to take a stab at this? — Reply to this email directly, view it on GitHub <#2299 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAA254VCYAP7IFUGP5DZNIDU5XUK5ANCNFSM5PTRP3UQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>

alanorth · 2022-05-19T09:15:54Z

node_exporter is crashing every fifteen seconds when I scrape due to this bug. I'm also running on a bare metal AMD EPYC system:

# lscpu | grep Model\ name:
Model name:          AMD EPYC 7451 24-Core Processor
BIOS Model name:     AMD EPYC 7451 24-Core Processor

Are there plans to tag a new release for this bug fix? Thank you!

rapl_collector: fix issue with invalid metric name (#2299)

SuperQ · 2022-05-31T19:43:17Z

Re-opening this, as I want to add a "make this a label" option to the collector.

stephankoelle · 2022-06-08T15:30:56Z

Same here with AMD EPYC 7401P 24-Core Processor

jardaKalus · 2022-06-13T10:20:57Z

Same here with AMD EPYC 7351 16-Core Processor

Add an optional flag to set the RAPL zone as a label, instead of as part of the metric name. Fixes: #2299 Signed-off-by: Ben Kochie <superq@gmail.com>

aneagoe · 2022-06-17T07:32:12Z

@SuperQ would be great to have a new release once this is closed. Thanks!

Add an optional flag to set the RAPL zone as a label, instead of as part of the metric name. Fixes: #2299 Signed-off-by: Ben Kochie <superq@gmail.com>

prometheus/node_exporter#2299

Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>

* [CHANGE] Merge metrics descriptions in textfile collector #2475 * [FEATURE] [node-mixin] Add darwin dashboard to mixin #2351 * [FEATURE] Add "isolated" metric on cpu collector on linux #2251 * [FEATURE] Add cgroup summary collector #2408 * [FEATURE] Add selinux collector #2205 * [FEATURE] Add slab info collector #2376 * [FEATURE] Add sysctl collector #2425 * [FEATURE] Also track the CPU Spin time for OpenBSD systems #1971 * [FEATURE] Add support for MacOS version #2471 * [ENHANCEMENT] [node-mixin] Add missing selectors #2426 * [ENHANCEMENT] [node-mixin] Change current datasource to grafana's default #2281 * [ENHANCEMENT] [node-mixin] Change disk graph to disk table #2364 * [ENHANCEMENT] [node-mixin] Change io time units to %util #2375 * [ENHANCEMENT] Ad user_wired_bytes and laundry_bytes on *bsd #2266 * [ENHANCEMENT] Add additional vm_stat memory metrics for darwin #2240 * [ENHANCEMENT] Add device filter flags to arp collector #2254 * [ENHANCEMENT] Add diskstats include and exclude device flags #2417 * [ENHANCEMENT] Add node_softirqs_total metric #2221 * [ENHANCEMENT] Add rapl zone name label option #2401 * [ENHANCEMENT] Add slabinfo collector #1799 * [ENHANCEMENT] Allow user to select port on NTP server to query #2270 * [ENHANCEMENT] collector/diskstats: Add labels and metrics from udev #2404 * [ENHANCEMENT] Enable builds against older macOS SDK #2327 * [ENHANCEMENT] qdisk-linux: Add exclude and include flags for interface name #2432 * [ENHANCEMENT] systemd: Expose systemd minor version #2282 * [ENHANCEMENT] Use netlink for tcpstat collector #2322 * [ENHANCEMENT] Use netlink to get netdev stats #2074 * [ENHANCEMENT] Add additional perf counters for stalled frontend/backend cycles #2191 * [ENHANCEMENT] Add btrfs device error stats #2193 * [BUGFIX] [node-mixin] Fix fsSpaceAvailableCriticalThreshold and fsSpaceAvailableWarning #2352 * [BUGFIX] Fix concurrency issue in ethtool collector #2289 * [BUGFIX] Fix concurrency issue in netdev collector #2267 * [BUGFIX] Fix diskstat reads and write metrics for disks with different sector sizes #2311 * [BUGFIX] Fix iostat on macos broken by deprecation warning #2292 * [BUGFIX] Fix NodeFileDescriptorLimit alerts #2340 * [BUGFIX] Sanitize rapl zone names #2299 * [BUGFIX] Add file descriptor close safely in test #2447 * [BUGFIX] Fix race condition in os_release.go #2454 * [BUGFIX] Skip ZFS IO metrics if their paths are missing #2451 Signed-off-by: Ben Kochie <superq@gmail.com>

* [CHANGE] Merge metrics descriptions in textfile collector #2475 * [FEATURE] [node-mixin] Add darwin dashboard to mixin #2351 * [FEATURE] Add "isolated" metric on cpu collector on linux #2251 * [FEATURE] Add cgroup summary collector #2408 * [FEATURE] Add selinux collector #2205 * [FEATURE] Add slab info collector #2376 * [FEATURE] Add sysctl collector #2425 * [FEATURE] Also track the CPU Spin time for OpenBSD systems #1971 * [FEATURE] Add support for MacOS version #2471 * [ENHANCEMENT] [node-mixin] Add missing selectors #2426 * [ENHANCEMENT] [node-mixin] Change current datasource to grafana's default #2281 * [ENHANCEMENT] [node-mixin] Change disk graph to disk table #2364 * [ENHANCEMENT] [node-mixin] Change io time units to %util #2375 * [ENHANCEMENT] Ad user_wired_bytes and laundry_bytes on *bsd #2266 * [ENHANCEMENT] Add additional vm_stat memory metrics for darwin #2240 * [ENHANCEMENT] Add device filter flags to arp collector #2254 * [ENHANCEMENT] Add diskstats include and exclude device flags #2417 * [ENHANCEMENT] Add node_softirqs_total metric #2221 * [ENHANCEMENT] Add rapl zone name label option #2401 * [ENHANCEMENT] Add slabinfo collector #1799 * [ENHANCEMENT] Allow user to select port on NTP server to query #2270 * [ENHANCEMENT] collector/diskstats: Add labels and metrics from udev #2404 * [ENHANCEMENT] Enable builds against older macOS SDK #2327 * [ENHANCEMENT] qdisk-linux: Add exclude and include flags for interface name #2432 * [ENHANCEMENT] systemd: Expose systemd minor version #2282 * [ENHANCEMENT] Use netlink for tcpstat collector #2322 * [ENHANCEMENT] Use netlink to get netdev stats #2074 * [ENHANCEMENT] Add additional perf counters for stalled frontend/backend cycles #2191 * [ENHANCEMENT] Add btrfs device error stats #2193 * [BUGFIX] [node-mixin] Fix fsSpaceAvailableCriticalThreshold and fsSpaceAvailableWarning #2352 * [BUGFIX] Fix concurrency issue in ethtool collector #2289 * [BUGFIX] Fix concurrency issue in netdev collector #2267 * [BUGFIX] Fix diskstat reads and write metrics for disks with different sector sizes #2311 * [BUGFIX] Fix iostat on macos broken by deprecation warning #2292 * [BUGFIX] Fix NodeFileDescriptorLimit alerts #2340 * [BUGFIX] Sanitize rapl zone names #2299 * [BUGFIX] Add file descriptor close safely in test #2447 * [BUGFIX] Fix race condition in os_release.go #2454 * [BUGFIX] Skip ZFS IO metrics if their paths are missing #2451 Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com>

This fixes a crash seen on HPE DL385 nodes [1]: panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name [1] prometheus/node_exporter#2299

* Fixup codespell (#2455) * Fix some mistakes * Switch to an ignore file. Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> * build(deps): bump github.com/jsimonetti/rtnetlink from 1.2.0 to 1.2.2 (#2459) Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](https://github.com/jsimonetti/rtnetlink/compare/v1.2.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/prometheus/client_golang (#2460) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.12.2 to 1.13.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.12.2...v1.13.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Wrap accesses of c.osFilename and c.osMtime in mutex to prevent race condition. Signed-off-by: Robin Nabel <rnabel@ucdavis.edu> * feat: add support macos version (#2471) Signed-off-by: Serhii Freidin <sfreydin@macpaw.com> Signed-off-by: Serhii Freidin <sfreydin@macpaw.com> * Merge metrics descriptions in textfile collector (#2475) The textfile collector will now provide a unified metric description (that will look like "Metric read from file/a.prom, file/b.prom") for metrics collected accross several text-files that don't already have a description. Also change the error handling in the textfile collector tests to ContinueOnError to better mirror the real-life use-case. Signed-off-by: Guillaume Espanel <guillaume.espanel.ext@ovhcloud.com> Signed-off-by: Guillaume Espanel <guillaume.espanel.ext@ovhcloud.com> * Skip zfs iostats (#2451) skip over the zfs IO metrics if their paths are missing Signed-off-by: tnextday <fw2k4@163.com> Signed-off-by: tnextday <fw2k4@163.com> * Add btrfs device error stats (#2193) * Improve metrics filesystem scanning logic * Makes ioctl syscalls to load the device error stats. * Adds filesystem mountpoint labels to existing metrics for ease of use. Signed-off-by: Marcus Cobden <leth@users.noreply.github.com> * Update common Prometheus files (#2473) Signed-off-by: prombot <prometheus-team@googlegroups.com> Signed-off-by: prombot <prometheus-team@googlegroups.com> * Release 1.4.0 (#2478) * [CHANGE] Merge metrics descriptions in textfile collector #2475 * [FEATURE] [node-mixin] Add darwin dashboard to mixin #2351 * [FEATURE] Add "isolated" metric on cpu collector on linux #2251 * [FEATURE] Add cgroup summary collector #2408 * [FEATURE] Add selinux collector #2205 * [FEATURE] Add slab info collector #2376 * [FEATURE] Add sysctl collector #2425 * [FEATURE] Also track the CPU Spin time for OpenBSD systems #1971 * [FEATURE] Add support for MacOS version #2471 * [ENHANCEMENT] [node-mixin] Add missing selectors #2426 * [ENHANCEMENT] [node-mixin] Change current datasource to grafana's default #2281 * [ENHANCEMENT] [node-mixin] Change disk graph to disk table #2364 * [ENHANCEMENT] [node-mixin] Change io time units to %util #2375 * [ENHANCEMENT] Ad user_wired_bytes and laundry_bytes on *bsd #2266 * [ENHANCEMENT] Add additional vm_stat memory metrics for darwin #2240 * [ENHANCEMENT] Add device filter flags to arp collector #2254 * [ENHANCEMENT] Add diskstats include and exclude device flags #2417 * [ENHANCEMENT] Add node_softirqs_total metric #2221 * [ENHANCEMENT] Add rapl zone name label option #2401 * [ENHANCEMENT] Add slabinfo collector #1799 * [ENHANCEMENT] Allow user to select port on NTP server to query #2270 * [ENHANCEMENT] collector/diskstats: Add labels and metrics from udev #2404 * [ENHANCEMENT] Enable builds against older macOS SDK #2327 * [ENHANCEMENT] qdisk-linux: Add exclude and include flags for interface name #2432 * [ENHANCEMENT] systemd: Expose systemd minor version #2282 * [ENHANCEMENT] Use netlink for tcpstat collector #2322 * [ENHANCEMENT] Use netlink to get netdev stats #2074 * [ENHANCEMENT] Add additional perf counters for stalled frontend/backend cycles #2191 * [ENHANCEMENT] Add btrfs device error stats #2193 * [BUGFIX] [node-mixin] Fix fsSpaceAvailableCriticalThreshold and fsSpaceAvailableWarning #2352 * [BUGFIX] Fix concurrency issue in ethtool collector #2289 * [BUGFIX] Fix concurrency issue in netdev collector #2267 * [BUGFIX] Fix diskstat reads and write metrics for disks with different sector sizes #2311 * [BUGFIX] Fix iostat on macos broken by deprecation warning #2292 * [BUGFIX] Fix NodeFileDescriptorLimit alerts #2340 * [BUGFIX] Sanitize rapl zone names #2299 * [BUGFIX] Add file descriptor close safely in test #2447 * [BUGFIX] Fix race condition in os_release.go #2454 * [BUGFIX] Skip ZFS IO metrics if their paths are missing #2451 Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> * Archived fixtures/udev similar to fixtures/sys to avoid go-get errors, fixes #2482 (#2485) Signed-off-by: Darshil Chanpura <darshil@thatwebsite.xyz> * Fix diskstats exclude flags (#2487) Correctly handle the new `collector.diskstats.device-exclude` flag to avoid errors when using the old `collector.diskstats.ignored-devices` flag. Fixes: https://github.com/prometheus/node_exporter/issues/2486 Signed-off-by: Ben Kochie <superq@gmail.com> * Update ISSUE_TEMPLATE.md Signed-off-by: Johannes 'fish' Ziemke <github@5pi.de> * Bump crypto and net CVE-2022-27191 CVE-2022-27664 (#2488) * Bump crypto and net CVE-2022-27191 CVE-2022-27664 Signed-off-by: Jason Culligan <jason.culligan@intel.com> * Fix hwmon label sanitizer (#2504) We don't need to fully sanitize the hwmon label values to metric/label name strings. * Just make sure they're valid UTF-8. * Always included the label metric to avoid group_left failures. Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> * build(deps): bump github.com/opencontainers/selinux Bumps [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) from 1.10.1 to 1.10.2. - [Release notes](https://github.com/opencontainers/selinux/releases) - [Commits](https://github.com/opencontainers/selinux/compare/v1.10.1...v1.10.2) --- updated-dependencies: - dependency-name: github.com/opencontainers/selinux dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/mdlayher/netlink from 1.6.0 to 1.6.2 Bumps [github.com/mdlayher/netlink](https://github.com/mdlayher/netlink) from 1.6.0 to 1.6.2. - [Release notes](https://github.com/mdlayher/netlink/releases) - [Changelog](https://github.com/mdlayher/netlink/blob/main/CHANGELOG.md) - [Commits](https://github.com/mdlayher/netlink/compare/v1.6.0...v1.6.2) --- updated-dependencies: - dependency-name: github.com/mdlayher/netlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/coreos/go-systemd/v22 from 22.3.2 to 22.4.0 (#2493) Bumps [github.com/coreos/go-systemd/v22](https://github.com/coreos/go-systemd) from 22.3.2 to 22.4.0. - [Release notes](https://github.com/coreos/go-systemd/releases) - [Commits](https://github.com/coreos/go-systemd/compare/v22.3.2...v22.4.0) --- updated-dependencies: - dependency-name: github.com/coreos/go-systemd/v22 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs/node-mixin: add fsMointpointSelector to alerts and dashboards (#2446) * docs/node-mixin: add fsMountpointSelector This adds the option to add a `mountpoint` selector to filesystem related alerts. The default is `mountpoint!=""`. * docs/node-mixins: add fsMountpointSelector to dashboards Signed-off-by: Jan Fajerski <jfajersk@redhat.com> * Use native endianness when encoding InetDiagMsg (#2508) Note however that the InetDiagMsg struct contains a InetDiagSockID member, which itself contains some members which are explicitly specified as big-endian in Linux kernel source: struct inet_diag_sockid { __be16 idiag_sport; __be16 idiag_dport; __be32 idiag_src[4]; __be32 idiag_dst[4]; __u32 idiag_if; __u32 idiag_cookie[2]; }; node_exporter currently does not use these members for anything, so this is acceptable (for now). Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com> * Add multiple listeners and systemd socket listener activation (#2393) Update exporter-toolkit to v0.8.1 to enable new listener support. Signed-off-by: Perry Naseck <git@perrynaseck.com> * Add procfs fallback to netdev collector (#2509) Some systems have broken netlink messages due to patched kernels. Since these messages can not be parsed, add a flag to fall back to parsing from `/proc/net/dev`. Fixes: https://github.com/prometheus/node_exporter/issues/2502 Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com> * build(deps): bump github.com/prometheus/client_model from 0.2.0 to 0.3.0 Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.2.0 to 0.3.0. - [Release notes](https://github.com/prometheus/client_model/releases) - [Commits](https://github.com/prometheus/client_model/compare/v0.2.0...v0.3.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_model dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/jsimonetti/rtnetlink from 1.2.2 to 1.2.3 Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.2.2 to 1.2.3. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](https://github.com/jsimonetti/rtnetlink/compare/v1.2.2...v1.2.3) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Fix btrfs device stats always being zero (#2516) * Respect rootfs path config option in btrfs ioctl * Fix btrfs device stats always being zero Signed-off-by: Marcus Cobden <leth@users.noreply.github.com> * readme: remove RHEL/CentOS/Fedora installation info (#2525) Copr community prometheus-exporters repository is obsoleted. Signed-off-by: Otto Sabart <seberm@seberm.com> Signed-off-by: Otto Sabart <seberm@seberm.com> * add RTNL version of netclass collector (#2492) * update rtnetlink package to v1.2.3 * add RTNL version of netclass collector that have all the metrics that netdev collector provides, too. Signed-off-by: Haoyu Sun <hasun@redhat.com> * update to golang.org/x/sys v0.1.0 (#2524) Signed-off-by: Manuel Stausberg <stausberg@denic.de> * Refactor netclass_rtnl collector (#2528) * Refactor netclass_rtnl collector Merge the netclass_rtnl collector into the netclass collector. * Disabled by default * Followup to #2492 Signed-off-by: Ben Kochie <superq@gmail.com> * Default GOMAXPROCS to 1 (#2530) Avoid running on all CPUs by limiting the Go runtime to one CPU by default. Avoids having Go routines schedule on every CPU, driving up the visible run queue length on high CPU count systems. This also helps workaround a kernel deadlock issue with reading from sysfs concurrently. See: * https://github.com/prometheus/node_exporter/issues/1880 * https://github.com/prometheus/node_exporter/issues/2500 Signed-off-by: Ben Kochie <superq@gmail.com> * Bump Go modules (#2531) * Update all Go modules to latest. * Update Go minimum version to 1.18. Signed-off-by: Ben Kochie <superq@gmail.com> * Release v1.5.0 NOTE: This changes the Go runtime "GOMAXPROCS" to 1. This is done to limit the concurrency of the exporter to 1 CPU thread at a time in order to avoid a race condition problem in the Linux kernel (#2500) and parallel IO issues on nodes with high numbers of CPUs/CPU threads (#1880). * [CHANGE] Default GOMAXPROCS to 1 #2530 * [FEATURE] Add multiple listeners and systemd socket listener activation #2393 * [ENHANCEMENT] Add RTNL version of netclass collector #2492, #2528 * [BUGFIX] Fix diskstats exclude flags #2487 * [BUGFIX] Bump go/x/crypt and go/x/net #2488 * [BUGFIX] Fix hwmon label sanitizer #2504 * [BUGFIX] Use native endianness when encoding InetDiagMsg #2508 * [BUGFIX] Fix btrfs device stats always being zero #2516 * [BUGFIX] Security: Update exporter-toolkit (CVE-2022-46146) #2531 Signed-off-by: Ben Kochie <superq@gmail.com> * Correct documentation for --web.config.file flag The --web.config flag changed to --web.config.file in 440a132c389dddd405b44d2d5e47157d1159e4d0 and was realised in the recent v1.5.0 release. Signed-off-by: Joe Groocock <me@frebib.net> * Log current value of GOMAXPROCS With `--runtime.gomaxprocs=0`, the GOMAXPROXS value will default to the number of logical CPUs. In this case, it is more useful to log the actual value than the value set by the user via the command-line. Signed-off-by: Simon Pasquier <spasquie@redhat.com> * add options for perf profilers Signed-off-by: mchtech <michu_an@126.com> * fix the docker link in the ISSUE_TEMPLATE Signed-off-by: Yury Vidineev <adeptg@gmail.com> * Replace mistaken ) with }, resulting in parsable promql Signed-off-by: Ryan J. Geyer <me@ryangeyer.com> * Update v1.5.0 release notes Add note about the change to the experimental web flag. Fixes: https://github.com/prometheus/node_exporter/issues/2535 Signed-off-by: Ben Kochie <superq@gmail.com> * Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * Migrate arp_linux.go to procfs Signed-off-by: James Bach <qweet.ing@gmail.com> Signed-off-by: James Bach <james.bach@wise.com> Signed-off-by: jalev <qweet.ing@gmail.com> * Change var name to match previous Signed-off-by: James Bach <james.bach@wise.com> Signed-off-by: jalev <qweet.ing@gmail.com> * Fix lint issues Signed-off-by: jalev <qweet.ing@gmail.com> * Bump perf-utils version to 0.6.0 This change updates the perf-utils library to 0.6.0 which has some fixes for automatically detecting the correct tracefs mountpoint if available. Signed-off-by: Daniel Hodges <hodges.daniel.scott@gmail.com> * Fix thermal_zone collector noise Add a check for missing/unreadable thermal zone stats and ignore if not availlable. Fixes: https://github.com/prometheus/node_exporter/issues/2552 Signed-off-by: Ben Kochie <superq@gmail.com> * Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * Enable uname collector on NetBSD too This collector works just fine without any further changes. Signed-off-by: Benny Siegert <bsiegert@gmail.com> * build(deps): bump github.com/mdlayher/netlink from 1.7.0 to 1.7.1 Bumps [github.com/mdlayher/netlink](https://github.com/mdlayher/netlink) from 1.7.0 to 1.7.1. - [Release notes](https://github.com/mdlayher/netlink/releases) - [Changelog](https://github.com/mdlayher/netlink/blob/main/CHANGELOG.md) - [Commits](https://github.com/mdlayher/netlink/compare/v1.7.0...v1.7.1) --- updated-dependencies: - dependency-name: github.com/mdlayher/netlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/josharian/native from 1.0.0 to 1.1.0 Bumps [github.com/josharian/native](https://github.com/josharian/native) from 1.0.0 to 1.1.0. - [Release notes](https://github.com/josharian/native/releases) - [Commits](https://github.com/josharian/native/compare/v1.0.0...v1.1.0) --- updated-dependencies: - dependency-name: github.com/josharian/native dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * fix cpustat when some cpus are offline Signed-off-by: Jia Xin <alexjx@gmail.com> * build(deps): bump github.com/prometheus/common from 0.37.0 to 0.39.0 Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.37.0 to 0.39.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](https://github.com/prometheus/common/compare/v0.37.0...v0.39.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update e2e output for new common version. Signed-off-by: Ben Kochie <superq@gmail.com> * Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * NetBSD support for the meminfo collector This depends on a recent change to golang.org/x/sys that adds a unix.SysctlUvmexp function. Signed-off-by: Benny Siegert <bsiegert@gmail.com> * memory_bsd: Fix a problem fetching the user wire count on FreeBSD Signed-off-by: David O'Rourke <david.orourke@gmail.com> * Optimize cpufreq collector Move metric descriptiions to package vars to avoid allocating them every time `NewCPUFreqCollector()` is called. Signed-off-by: Ben Kochie <superq@gmail.com> * build(deps): bump github.com/hodgesds/perf-utils from 0.6.0 to 0.7.0 Bumps [github.com/hodgesds/perf-utils](https://github.com/hodgesds/perf-utils) from 0.6.0 to 0.7.0. - [Release notes](https://github.com/hodgesds/perf-utils/releases) - [Commits](https://github.com/hodgesds/perf-utils/compare/v0.6.0...v0.7.0) --- updated-dependencies: - dependency-name: github.com/hodgesds/perf-utils dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Deprecate ntp collector The ntp collector has always been a source of confusion and problems. The data it produces is more of a blackbox probe against an NTP server. The time sync / offset data produced is not what users expect. Mark this collector as deprecated to be removed in v2.0.0 Signed-off-by: Ben Kochie <superq@gmail.com> * Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * build(deps): bump golang.org/x/net from 0.4.0 to 0.7.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.4.0 to 0.7.0. - [Release notes](https://github.com/golang/net/releases) - [Commits](https://github.com/golang/net/compare/v0.4.0...v0.7.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * Remove metrics of offline CPUs in CPU collector Signed-off-by: Haoyu Sun <hasun@redhat.com> * build(deps): bump github.com/jsimonetti/rtnetlink from 1.3.0 to 1.3.1 Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](https://github.com/jsimonetti/rtnetlink/compare/v1.3.0...v1.3.1) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/opencontainers/selinux Bumps [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) from 1.10.2 to 1.11.0. - [Release notes](https://github.com/opencontainers/selinux/releases) - [Commits](https://github.com/opencontainers/selinux/compare/v1.10.2...v1.11.0) --- updated-dependencies: - dependency-name: github.com/opencontainers/selinux dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0 Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.5.0 to 0.6.0. - [Release notes](https://github.com/golang/sys/releases) - [Commits](https://github.com/golang/sys/compare/v0.5.0...v0.6.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update exporter-toolkit * Bump exporter-toolkit to the latest release. * Use new toolkit landing page function. * Update kingpin flags. Signed-off-by: Ben Kochie <superq@gmail.com> * Bump exporter-toolkit Pick up the fixes for 32-bit mode and updated HTML template. Signed-off-by: Ben Kochie <superq@gmail.com> * Update build * Update Go to 1.20 * Update golangci-lint. * Update CI orb. * Fix staticcheck issue in perf collector. Signed-off-by: Ben Kochie <superq@gmail.com> * Allow root path as metrics path. (#2590) Signed-off-by: LamGC <lam827@lamgc.net> * Fix spelling issues Minor typo fixup. Signed-off-by: Ben Kochie <superq@gmail.com> * interrupts_linux: Fix fields on aarch64 (#2631) * interrupts_linux: Fix fields on aarch64 Fixes #2557 --------- Signed-off-by: Daniël van Eeden <git@myname.nl> * feat: add support for cpu freq governor metrics Signed-off-by: Lukas Coppens <lukas.coppens@be-mobile.com> * feat: add support for cpu freq governor metrics Signed-off-by: Lukas Coppens <lukas.coppens@be-mobile.com> * Reduce priviliges needed for btrfs device stats Signed-off-by: Marcus Cobden <leth@users.noreply.github.com> * Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * build(deps): bump github.com/safchain/ethtool from 0.2.0 to 0.3.0 Bumps [github.com/safchain/ethtool](https://github.com/safchain/ethtool) from 0.2.0 to 0.3.0. - [Release notes](https://github.com/safchain/ethtool/releases) - [Commits](https://github.com/safchain/ethtool/compare/v0.2.0...v0.3.0) --- updated-dependencies: - dependency-name: github.com/safchain/ethtool dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/prometheus/common from 0.41.0 to 0.42.0 Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.41.0 to 0.42.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](https://github.com/prometheus/common/compare/v0.41.0...v0.42.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * NetBSD support for CPU collector (#2626) * Added CPU collector for NetBSD to provide load and temperature statistics --------- Signed-off-by: Matthias Petermann <mp@petermann-it.de> * feat: added suspended as a node_zfs_zpool_state (#2449) Signed-off-by: Pablo Caderno <kaderno@gmail.com> * build(deps): bump github.com/mdlayher/netlink from 1.7.1 to 1.7.2 Bumps [github.com/mdlayher/netlink](https://github.com/mdlayher/netlink) from 1.7.1 to 1.7.2. - [Release notes](https://github.com/mdlayher/netlink/releases) - [Changelog](https://github.com/mdlayher/netlink/blob/main/CHANGELOG.md) - [Commits](https://github.com/mdlayher/netlink/compare/v1.7.1...v1.7.2) --- updated-dependencies: - dependency-name: github.com/mdlayher/netlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/prometheus/client_golang Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.14.0 to 1.15.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.14.0...v1.15.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * doc: added undocumented include and exclude flags (#2670) * doc: added undocumented exclude flags Signed-off-by: David Calvert <david@0xdc.me> * Expose administrative state of network interfaces as 'adminstate'. (#2515) Signed-off-by: Maximilian Wilhelm <max@sdn.clinic> * Use go-runit fork, mark collector as deprecated Signed-off-by: Johannes Ziemke <github@5pi.de> * build(deps): bump github.com/jsimonetti/rtnetlink from 1.3.1 to 1.3.2 (#2673) Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.3.1 to 1.3.2. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](https://github.com/jsimonetti/rtnetlink/compare/v1.3.1...v1.3.2) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * docs (node/mixin): fix annotation for Skew alert (#2671) This updates the annotation for the NodeClockSkewDetected mixin alert to match the new threshold set. Original discussion was in this PR: https://github.com/prometheus/node_exporter/pull/1480 I spent an embarrassingly large amount of time trying to figure out how the heck that alert would mean 300s of clock skew. Turns out the annotation was just left the same after the threshold change. Signed-off-by: Will Bollock <wbollock@linode.com> * collector/netisr_freebsd.go: Added collector for netisr subsystem. (#2668) Signed-off-by: Jonathan Davies <jpds@protonmail.com> * Do not hand define struct clockinfo here. Instead use the version from (#2663) x/sys/unix. The clockinfo struct was altered beginning of 2021 and this code was not adjusted. Signed-off-by: Claudio Jeker <claudio@openbsd.org> * Fix filesystem collector for OpenBSD to not print loads of zero bytes in name (#2637) Use the filesystem collector for all OpenBSD archs, there is no reason to only use it on amd64 systems. Signed-off-by: Claudio Jeker <claudio@openbsd.org> * collector: fix comment and remove redundant parentheses (#2691) Signed-off-by: cui fliter <imcusg@gmail.com> * bcache: remove cache_readaheads_totals metrics #2103 (#2583) * bcache: remove cache_readaheads_totals metrics #2103 Signed-off-by: Saleh Sal <0xack13@gmail.com> * Append bcacheReadaheadMetrics when CacheReadaheads value exists Signed-off-by: Saleh Sal <0xack13@gmail.com> * Update test cases for cachereadahead greater than zero Signed-off-by: Saleh Sal <0xack13@gmail.com> --------- Signed-off-by: Saleh Sal <0xack13@gmail.com> * Fix CVE-2022-41723 by upgrading x/net to v0.10.0 (#2694) Signed-off-by: Nitin Shelke <nshelke@cloudera.com> * Update e2e output fixtures (#2696) Fix up correct e2e output for node_power_supply_info. Signed-off-by: Ben Kochie <superq@gmail.com> * Update Go modules (#2695) Update Prometheus modules to latest releases. * Add missing fixtures for cpus online/offline. Signed-off-by: Ben Kochie <superq@gmail.com> * fix(zfs): add `memory_available_bytes`, fix `dbufstats` filename on Linux (#2687) * Fix zfs memory_available_bytes collector * Fix zfs dbufstats collector --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * Update Go module for ema/qdisc (#2700) * Update Go module for ema/qdisc --------- Signed-off-by: jbradleynh <jbradley@fastly.com> * Deprecate supervisord collector Mark the `supervisord` as deprecated. This process supevisor, like `runit`, is of scope for the node_exporter. Signed-off-by: Ben Kochie <superq@gmail.com> * collector/diskstats: Use SCSI_IDENT_SERIAL as serial (#2612) On most hard drives, `ID_SERIAL_SHORT` and `SCSI_IDENT_SERIAL` are identical, but on some SAS drives they do differ. In that case, `SCSI_IDENT_SERIAL` corresponds to the serial number printed on the drive label, and to the value returned by `smartctl -i`. So use that value by default for the `serial` label on the `node_disk_info` metric, and fallback to `ID_SERIAL_SHORT` only if it's undefined. Signed-off-by: Benoît Knecht <bknecht@protonmail.ch> * softnet: additionals metrics from softnet_data, (#2592) * softnet: additionals metrics from softnet_data, https://github.com/prometheus/procfs/pull/473 --------- Signed-off-by: remi <remijouannet@gmail.com> Signed-off-by: Rémi Jouannet <remijouannet@gmail.com> * exposing softirq metrics (#2294) Signed-off-by: abbeywoodyear <abbey.woodyear@thehutgroup.com> * netlink: read missing attributes from sysfs (#2669) Read missing dev_id, name_assign_type, and addr_assign_type from sysfs, since they only take a device-specific lock and not the whole RTNL lock. This means reading them is much less impactful on other system processes than many of the other attributes in sysfs that do take the RTNL lock. Signed-off-by: Dan Williams <dcbw@redhat.com> * Update ansible role in README.md (#2702) https://github.com/cloudalchemy/ansible-node-exporter has been deprecated Signed-off-by: Johannes Dilli <jd1@users.noreply.github.com> * Release v1.6.0 (#2701) * [CHANGE] Fix cpustat when some cpus are offline #2318 * [CHANGE] Remove metrics of offline CPUs in CPU collector #2605 * [CHANGE] Deprecate ntp collector #2603 * [CHANGE] Remove bcache `cache_readaheads_totals` metrics #2583 * [CHANGE] Deprecate supervisord collector #2685 * [FEATURE] Enable uname collector on NetBSD #2559 * [FEATURE] NetBSD support for the meminfo collector #2570 * [FEATURE] NetBSD support for CPU collector #2626 * [FEATURE] Add FreeBSD collector for netisr subsystem #2668 * [FEATURE] Add softirqs collector #2669 * [ENHANCEMENT] Add suspended as a `node_zfs_zpool_state` #2449 * [ENHANCEMENT] Add administrative state of Linux network interfaces #2515 * [ENHANCEMENT] Log current value of GOMAXPROCS #2537 * [ENHANCEMENT] Add profiler options for perf collector #2542 * [ENHANCEMENT] Allow root path as metrics path #2590 * [ENHANCEMENT] Add cpu frequency governor metrics #2569 * [ENHANCEMENT] Add new landing page #2622 * [ENHANCEMENT] Reduce privileges needed for btrfs device stats #2634 * [ENHANCEMENT] Add ZFS `memory_available_bytes` #2687 * [ENHANCEMENT] Use `SCSI_IDENT_SERIAL` as serial in diskstats #2612 * [ENHANCEMENT] Read missing from netlink netclass attributes from sysfs #2669 * [BUGFIX] perf: fixes for automatically detecting the correct tracefs mountpoints #2553 * [BUGFIX] Fix `thermal_zone` collector noise @2554 * [BUGFIX] Fix a problem fetching the user wire count on FreeBSD 2584 * [BUGFIX] interrupts: Fix fields on linux aarch64 #2631 * [BUGFIX] Remove metrics of offline CPUs in CPU collector #2605 * [BUGFIX] Fix OpenBSD filesystem collector string parsing #2637 * [BUGFIX] Fix bad reporting of `node_cpu_seconds_total` in OpenBSD #2663 Signed-off-by: Ben Kochie <superq@gmail.com> * build(deps): bump github.com/beevik/ntp from 0.3.0 to 1.0.0 Bumps [github.com/beevik/ntp](https://github.com/beevik/ntp) from 0.3.0 to 1.0.0. - [Release notes](https://github.com/beevik/ntp/releases) - [Changelog](https://github.com/beevik/ntp/blob/main/RELEASE_NOTES.md) - [Commits](https://github.com/beevik/ntp/compare/v0.3.0...v1.0.0) --- updated-dependencies: - dependency-name: github.com/beevik/ntp dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/prometheus/procfs from 0.10.0 to 0.10.1 Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs) from 0.10.0 to 0.10.1. - [Release notes](https://github.com/prometheus/procfs/releases) - [Commits](https://github.com/prometheus/procfs/compare/v0.10.0...v0.10.1) --- updated-dependencies: - dependency-name: github.com/prometheus/procfs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/jsimonetti/rtnetlink from 1.3.2 to 1.3.3 Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.3.2 to 1.3.3. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](https://github.com/jsimonetti/rtnetlink/compare/v1.3.2...v1.3.3) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Parallelize stat calls in Linux filesystem collector. This change adds the ability to process multiple stat calls in parallel. Processing is rate-limited based on the new flag `collector.filesystem.stat-workers` (default 4). Caveat: filesystem stats information is no longer in the same order as returned by `/proc/1/mounts`. This should not be an issue. Caveat: This change currently uses unbuffered channels to prove correctness without reliance on buffers. Buffered channels will yield superior performance. Signed-off-by: Erica Mays <erica@emays.dev> * fix misspel in CHANGELOG.md (#2717) Signed-off-by: juzhao <juzhao@redhat.com> * Bump wifi Go module (#2719) Update github.com/mdlayher/wifi to the latest commit. Signed-off-by: Ben Kochie <superq@gmail.com> * Bump ethtool library (#2720) Update to latest release. Signed-off-by: Ben Kochie <superq@gmail.com> * add missing linkspeeds (#2711) Signed-off-by: Cam Cope <ccope@crusoeenergy.com> * Update common Prometheus files (#2723) Signed-off-by: prombot <prometheus-team@googlegroups.com> * Update golangci-lint config (#2722) * Migrate from Python codespell to golangci-lint misspell. * Inline errcheck exclude list in the golangci-lint config. Signed-off-by: Ben Kochie <superq@gmail.com> * Add mountpoint to NodeFilesystem alerts This helps to identify alerting filesystem. Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Decrease NodeFilesystem pending time to 15m 30m is too long and there is a risk of running out of disk space/inodes completely if something is filling up disk very fast (like log file). Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Add CPU and memory alerts Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Add failed systemd service alert Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Decrease NodeNetwork*Errs pending period Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Set 'at' everywhere as preposition for instance Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Add NodeDiskIOSaturation alert Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Add %(nodeExporterSelector)s to Network and conntrack alerts Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Add diskDevice selector Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Fix NodeMemoryHighUtilization alert Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Add NodeSystemSaturation and NodeMemoryMajorPagesFaults Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Decrease NodeSystemdServiceFailed severity to warning Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Extend alert description Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Add comma after 'mounted on' Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Add thresholds for memory alerts Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Add thresholds for memory, disk and system alerts Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Set severity to NodeCPUHighUsage to info Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Update NodeSystemSaturation severity Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Revert alerts pending durtions Signed-off-by: Vitaly Zhuravlev <v-zhuravlev@users.noreply.github.com> * Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * Add cpu vulnerabilities reporting from sysfs (#2721) * Add cpu vulnerabilities reporting from sysfs --------- Signed-off-by: Michal Wasilewski <michal@mwasilewski.net> * build(deps): bump github.com/beevik/ntp from 1.0.0 to 1.1.1 Bumps [github.com/beevik/ntp](https://github.com/beevik/ntp) from 1.0.0 to 1.1.1. - [Release notes](https://github.com/beevik/ntp/releases) - [Changelog](https://github.com/beevik/ntp/blob/main/RELEASE_NOTES.md) - [Commits](https://github.com/beevik/ntp/compare/v1.0.0...v1.1.1) --- updated-dependencies: - dependency-name: github.com/beevik/ntp dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/prometheus/client_golang Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.15.1 to 1.16.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.15.1...v1.16.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Add include and exclude filter for hwmon collector (#2699) * Add include and exclude flags chip name flags to hwmon collector, following example in systemd collector --------- Signed-off-by: Conall O'Brien <conall@conall.net> Co-authored-by: Ben Kochie <superq@gmail.com> * Add missing ethtool flag documentation (#2743) Signed-off-by: Gabi Davar <grizzly.nyo@gmail.com> * Update all Include and Exclude variables to use the systemdUnit naming (#2740) prefix. Leave an annotation about using regexps instead of device_filter.go, so @SuperQ doesn't need to remember everything. Signed-off-by: Conall O'Brien <conall@conall.net> * Fixup hwmon chip include (#2739) Use the correct include value to the device filter function. * Add new bogus hwmon fixture. * Update end-to-end test to use hwmon chip include flag. Signed-off-by: Ben Kochie <superq@gmail.com> * Release v1.6.1 (#2747) Rebuild with latest Go compiler bugfix release. Signed-off-by: Ben Kochie <superq@gmail.com> * Synchronize common files from prometheus/prometheus (#2736) * Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * Fixup linting issues * Disbale unused-parameter check. * Fixup minor linting issues. Signed-off-by: Ben Kochie <superq@gmail.com> --------- Signed-off-by: prombot <prometheus-team@googlegroups.com> Signed-off-by: Ben Kochie <superq@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com> * Update common Prometheus files (#2752) Signed-off-by: prombot <prometheus-team@googlegroups.com> * Include drm collector in README The DRM collector was missing in the README, this change includes it together with a short description. Signed-off-by: L <3177243+LukeLR@users.noreply.github.com> * collector/netdev_linux.go: Fallback to 32-bit stats (#2757) On some platforms, `msg.Attributes.Stats64` is `nil` because the kernel doesn't expose 64-bit stats. In that case, return `msg.Attributes.Stats` instead, which are the 32-bit equivalent. Note that `RXOtherhostDropped` isn't available in that case, so we hardcode it to zero. Fixes #2756. Signed-off-by: Benoît Knecht <bknecht@protonmail.ch> * build(deps): bump github.com/beevik/ntp from 1.1.1 to 1.3.0 (#2762) Signed-off-by: Ben Kochie <superq@gmail.com> * build(deps): bump github.com/prometheus/procfs from 0.11.0 to 0.11.1 (#2763) Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs) from 0.11.0 to 0.11.1. - [Release notes](https://github.com/prometheus/procfs/releases) - [Commits](https://github.com/prometheus/procfs/compare/v0.11.0...v0.11.1) --- updated-dependencies: - dependency-name: github.com/prometheus/procfs dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/jsimonetti/rtnetlink from 1.3.3 to 1.3.4 (#2765) Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.3.3 to 1.3.4. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](https://github.com/jsimonetti/rtnetlink/compare/v1.3.3...v1.3.4) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Drop redundant GOOS build tags if already in filename Drop redundant GOOS build tags at start of file if the constraint is already specified by the filename, e.g. foo_GOOS.go or foo_GOOS_GOARCH.go, avoiding potential confusion in future. cf. https://pkg.go.dev/cmd/go#hdr-Build_constraints Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com> * Sync build tags in *_test.go (#2767) Ensure that unwanted tests are correctly excluded when various build tags are specified, i.e. when the code that they test would be excluded from compilation. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com> * Upgrade github.com/ema/qdisc to v1.0.0 to improve qdisc collector (#2779) performance Signed-off-by: Oliver Geiselhardt-Herms <ogh@deepl.com> Co-authored-by: Oliver Geiselhardt-Herms <ogh@deepl.com> * Add CPU MHz as the value for "node_cpu_info" metric For CPUs which don't have an available (or insertable) cpufreq driver, the /proc/cpuinfo file can sometimes have accurate CPU core frequency measurements. This change replaces the constant value of "1" for the "node_cpu_info" metric with the parsed CPU MHz value from /proc/cpuinfo for each core. Signed-off-by: John Kordich <jkordich@gmail.com> * Update e2e-output.txt with new expected metric values Changes the e2e-output.txt file to have the expected CPU MHz values for the node_cpu_info metric. Signed-off-by: John Kordich <jkordich@gmail.com> * Add new node_cpu_frequency_hertz metric Revert changes to node_cpu_info and add new node_cpu_frequency_hertz metric for measuring CPU frequency from /proc/cpuinfo Signed-off-by: John Kordich <jkordich@gmail.com> * Change log message from Warn to Debug Signed-off-by: John Kordich <jkordich@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: John Kordich <jkordich@gmail.com> * fix(qdisc) flag naming corrected for consistency (#2782) * fix collector qdisc flag naming for consistency --------- Signed-off-by: jbradleynh <jbradley@fastly.com> * btrfs: close btrfs.FS handle after use Despite being quite hard to provoke (< 10% in my testing), the btrfs collector would occasionally leave stale FDs relating to btrfs mountpoints, making the filesystems unable to be unmounted. Fixes: #2772. Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com> * Update to Go 1.21 (#2796) * Update Go build to 1.21. * Update machine images to Ubuntu 22.04 current. Signed-off-by: Ben Kochie <superq@gmail.com> * Optionally fetch ARP stats via rtnetlink instead of procfs (#2777) * Optionally fetch ARP stats via rtnetlink instead of procfs Implement collection of ARP stats via rtnetlink to work around shortcomings in the output of /proc/net/arp, which truncates InfiniBand link-layer addresses. Fixes: #2776 --------- Signed-off-by: Daniel Swarbrick <daniel.swarbrick@gmail.com> Co-authored-by: Ben Kochie <superq@gmail.com> * build(deps): bump golang.org/x/sys from 0.10.0 to 0.12.0 (#2797) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.10.0 to 0.12.0. - [Commits](https://github.com/golang/sys/compare/v0.10.0...v0.12.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update common Prometheus files (#2798) Signed-off-by: prombot <prometheus-team@googlegroups.com> * Add ZFS freebsd per dataset stats (#2753) * Rename parsePoolObjsetFile to parseLinuxPoolObjsetFile to better reflect it's scope * Create a new parseFreeBSDPoolObjsetStats function, to generate a list of per pool metrics to be queried via sysctl --------- Signed-off-by: Conall O'Brien <conall@conall.net> * Move RO status before error return Signed-off-by: Metbog <metbog@gmail.com> * Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * fix(zfs) zfs `arcstats.p` on FreeBSD 14.0+ (#2754) * dongjiang, fix zfs arcstats.p Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * dongjiang, fix gofmt -s Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * change warn log to debug log by code review Signed-off-by: dongjiang1989 <dongjiang1989@126.com> --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * Fix promhttp_metric_handler_errors_total metric not being disabled by flag Signed-off-by: ToMe25 <ToMe25@gmx.de> * build(deps): bump github.com/prometheus/client_golang (#2815) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.16.0 to 1.17.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.16.0...v1.17.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix inconsistent variable name, to address compilation issue (#2820) https://github.com/prometheus/node_exporter/issues/2819 Signed-off-by: Conall O'Brien <conall@conall.net> * Update README.md: update the 'more details' url in the section 'TLS endpoint' (#2814) * Update README.md: correct the wrong url(link to exporter-toolkit web-config) in the section 'TLS endpoint' Signed-off-by: yang-stressfree <68363665+yang-stressfree@users.noreply.github.com> * Update README.md Co-authored-by: Ben Kochie <superq@gmail.com> Signed-off-by: yang-stressfree <68363665+yang-stressfree@users.noreply.github.com> --------- Signed-off-by: yang-stressfree <68363665+yang-stressfree@users.noreply.github.com> Co-authored-by: Ben Kochie <superq@gmail.com> * Update common Prometheus files Signed-off-by: prombot <prometheus-team@googlegroups.com> * build(deps): bump golang.org/x/net from 0.11.0 to 0.17.0 Bumps [golang.org/x/net](https://github.com/golang/net) from 0.11.0 to 0.17.0. - [Commits](https://github.com/golang/net/compare/v0.11.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/net dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> * build(deps): bump github.com/prometheus/procfs from 0.11.1 to 0.12.0 Bumps [github.com/prometheus/procfs](https://github.com/prometheus/procfs) from 0.11.1 to 0.12.0. - [Release notes](https://github.com/prometheus/procfs/releases) - [Commits](https://github.com/prometheus/procfs/compare/v0.11.1...v0.12.0) --- updated-dependencies: - dependency-name: github.com/prometheus/procfs dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update e2e fixtures Update for fixes in https://github.com/prometheus/procfs/pull/543 Signed-off-by: Ben Kochie <superq@gmail.com> * NFSd: fix nfsd v4 index miss (#2824) * fix nfsd v4 index miss --------- Signed-off-by: dongjiang1989 <dongjiang1989@126.com> * fix readme about expose memory statistics Signed-off-by: joey <zchengjoey@gmail.com> * Fix typo in CHANGELOG.md (#2836) Use # consistently for PR number. Signed-off-by: nemobis <federicoleva@tiscali.it> * Update common Prometheus files (#2840) Signed-off-by: prombot <prometheus-team@googlegroups.com> * build(deps): bump github.com/prometheus/common from 0.44.0 to 0.45.0 (#2837) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.44.0 to 0.45.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](https://github.com/prometheus/common/compare/v0.44.0...v0.45.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/prometheus/client_model (#2838) Bumps [github.com/prometheus/client_model](https://github.com/prometheus/client_model) from 0.4.1-0.20230718164431-9a2bf3000d16 to 0.5.0. - [Release notes](https://github.com/prometheus/client_model/releases) - [Commits](https://github.com/prometheus/client_model/commits/v0.5.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_model dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Release 1.7.0 (#2845) * [FEATURE] Add ZFS freebsd per dataset stats #2753 * [FEATURE] Add cpu vulnerabilities reporting from sysfs #2721 * [ENHANCEMENT] Parallelize stat calls in Linux filesystem collector #1772 * [ENHANCEMENT] Add missing linkspeeds to ethtool collector 2711 * [ENHANCEMENT] Add CPU MHz as the value for `node_cpu_info` metric #2778 * [ENHANCEMENT] Improve qdisc collector performance #2779 * [ENHANCEMENT] Add include and exclude filter for hwmon collector #2699 * [ENHANCEMENT] Optionally fetch ARP stats via rtnetlink instead of procfs #2777 * [BUFFIX] Fix ZFS arcstats on FreeBSD 14.0+ 2754 * [BUGFIX] Fallback to 32-bit stats in netdev #2757 * [BUGFIX] Close btrfs.FS handle after use #2780 * [BUGFIX] Move RO status before error return #2807 * [BUFFIX] Fix `promhttp_metric_handler_errors_total` being always active #2808 * [BUGFIX] Fix nfsd v4 index miss #2824 Signed-off-by: Ben Kochie <superq@gmail.com> * Add NodeBondingDegraded alert (#2843) Signed-off-by: Ayoub Nasr <ayoub.nasr@scality.com> * Make filesystem space prediction window configurable (#2844) Signed-off-by: fitz123 <alugovoi@ordercapital.com> * NFSd: handle new wdeleg_getattr attribute in /proc/net/rpc/nfsd (#2810) This attribute was introduced it v6.6-rc1. The relevant changes in procfs were merged here: https://github.com/prometheus/procfs/pull/574 and are part of procfs v0.11.2 I have also figured out that the stat should be part of the v4 ops counters struct, but that will need changes to both procfs and this code. Since people are already using 6.6-rc1, I think it's better to get the code out there --- even if they don't care about wdeleg_getattr, currently they get _no_ nfsd stats with 6.6-rc1. I will make two follow-up PRs to clean this up in the next releases of procfs and node-exporter. Signed-off-by: Tobias Klausmann <klausman@schwarzvogel.de> * Update common Prometheus files (#2851) Signed-off-by: prombot <prometheus-team@googlegroups.com> * Update containerization warnings (#2855) Running node_exporter in containers is now a fairly well understood problem. Replace the warnings with something less dire and more prescriptive. Signed-off-by: Ben Kochie <superq@gmail.com> * Fix debug log in cpu collector (#2857) Signed-off-by: Simon Pasquier <spasquie@redhat.com> * build(deps): bump github.com/alecthomas/kingpin/v2 from 2.3.2 to 2.4.0 (#2865) Bumps [github.com/alecthomas/kingpin/v2](https://github.com/alecthomas/kingpin) from 2.3.2 to 2.4.0. - [Release notes](https://github.com/alecthomas/kingpin/releases) - [Commits](https://github.com/alecthomas/kingpin/compare/v2.3.2...v2.4.0) --- updated-dependencies: - dependency-name: github.com/alecthomas/kingpin/v2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump howett.net/plist from 1.0.0 to 1.0.1 (#2862) Bumps [howett.net/plist](https://github.com/DHowett/go-plist) from 1.0.0 to 1.0.1. - [Commits](https://github.com/DHowett/go-plist/compare/v1.0.0...v1.0.1) --- updated-dependencies: - dependency-name: howett.net/plist dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add new collector and metrics for XFRM (#2544) (#2866) Signed-off-by: Gavin Lam <gavin.oss@tutamail.com> * build(deps): bump github.com/jsimonetti/rtnetlink from 1.3.5 to 1.4.0 (#2864) Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.3.5 to 1.4.0. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](https://github.com/jsimonetti/rtnetlink/compare/v1.3.5...v1.4.0) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump golang.org/x/sys from 0.13.0 to 0.15.0 (#2863) Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.13.0 to 0.15.0. - [Commits](https://github.com/golang/sys/compare/v0.13.0...v0.15.0) --- updated-dependencies: - dependency-name: golang.org/x/sys dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Add TCPOFOQueue to default netstat metrics (#2867) Adds a count for TCP packets received out of orders. This can be an indication that there is packet loss on the way packets travel towards this server. In that case, the sender will retransmit (and we can already monitor the Tcp_RetransSegs there), but we have no way to monitor the packet loss on the receiver side. When a packet is received and the receiver detects previous one missing, it will increase the TCPOFOQueue counter and reply with selective ACK to the sender, both possible indications of packet loss. Confirmation of packet loss can be achieved by taking packet captures, ignoring wireshark analysis, and carefully looking at data being retransmitted based on the TCP seq. Just like RetransSegs, TCPOFOQueue should be interesting for any deployment as a mean to detect packet loss, so here suggesting adding it to the default list. Signed-off-by: François Rigault <frigo@amadeus.com> Co-authored-by: François Rigault <frigo@amadeus.com> * Update common Prometheus files (#2870) Signed-off-by: prombot <prometheus-team@googlegroups.com> * Add mitigation information to the linux vulnerabilities collector (#2806) While the CPU vulnerabilities collector has been added in https://github.com/prometheus/node_exporter/pull/2721 , it's currently not including information regarding the mitigation strategy used for a given vulnerability. This information can be quite valuable, as often times different mitigation strategies come with a different performance impact. This commit adds a third label to the cpu_vulnerabilities_info metric, to include the "mitigation" used for a given vulnerability - if a given vulnerability is not affecting a node or the node is still vulnerable, the mitigation is expected to be empty. Signed-off-by: João Lima <jlima@cloudflare.com> * Update common Prometheus files (#2872) Signed-off-by: prombot <prometheus-team@googlegroups.com> * build(deps): bump golang.org/x/crypto from 0.14.0 to 0.17.0 (#2877) Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.14.0 to 0.17.0. - [Commits](https://github.com/golang/crypto/compare/v0.14.0...v0.17.0) --- updated-dependencies: - dependency-name: golang.org/x/crypto dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update common Prometheus files (#2879) Signed-off-by: prombot <prometheus-team@googlegroups.com> * build(deps): bump github.com/prometheus/exporter-toolkit (#2885) Bumps [github.com/prometheus/exporter-toolkit](https://github.com/prometheus/exporter-toolkit) from 0.10.0 to 0.11.0. - [Release notes](https://github.com/prometheus/exporter-toolkit/releases) - [Changelog](https://github.com/prometheus/exporter-toolkit/blob/master/CHANGELOG.md) - [Commits](https://github.com/prometheus/exporter-toolkit/compare/v0.10.0...v0.11.0) --- updated-dependencies: - dependency-name: github.com/prometheus/exporter-toolkit dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/beevik/ntp from 1.3.0 to 1.3.1 (#2886) Bumps [github.com/beevik/ntp](https://github.com/beevik/ntp) from 1.3.0 to 1.3.1. - [Release notes](https://github.com/beevik/ntp/releases) - [Changelog](https://github.com/beevik/ntp/blob/main/RELEASE_NOTES.md) - [Commits](https://github.com/beevik/ntp/compare/v1.3.0...v1.3.1) --- updated-dependencies: - dependency-name: github.com/beevik/ntp dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/prometheus/client_golang (#2887) Bumps [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang) from 1.17.0 to 1.18.0. - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](https://github.com/prometheus/client_golang/compare/v1.17.0...v1.18.0) --- updated-dependencies: - dependency-name: github.com/prometheus/client_golang dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update common Prometheus files (#2897) Signed-off-by: prombot <prometheus-team@googlegroups.com> * diskstats: ignore zram devices on linux systems by default (#2898) Signed-off-by: DBS-ST-VIT <dbs-st-vit@users.noreply.github.com> Co-authored-by: DBS-ST-VIT <dbs-st-vit@users.noreply.github.com> * Bump golang-builder version (#2908) Signed-off-by: Alper Polat <gitperr@gmail.com> * exec_bsd: Fix labels for vm.stats.sys.v_syscall sysctl (#2895) Signed-off-by: David O'Rourke <david.orourke@gmail.com> * chore:remove constant from function (#2884) Signed-off-by: tyltr <tylitianrui@126.com> * build(deps): bump github.com/prometheus/common from 0.45.0 to 0.46.0 (#2910) Bumps [github.com/prometheus/common](https://github.com/prometheus/common) from 0.45.0 to 0.46.0. - [Release notes](https://github.com/prometheus/common/releases) - [Commits](https://github.com/prometheus/common/compare/v0.45.0...v0.46.0) --- updated-dependencies: - dependency-name: github.com/prometheus/common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/jsimonetti/rtnetlink from 1.4.0 to 1.4.1 (#2909) Bumps [github.com/jsimonetti/rtnetlink](https://github.com/jsimonetti/rtnetlink) from 1.4.0 to 1.4.1. - [Release notes](https://github.com/jsimonetti/rtnetlink/releases) - [Commits](https://github.com/jsimonetti/rtnetlink/compare/v1.4.0...v1.4.1) --- updated-dependencies: - dependency-name: github.com/jsimonetti/rtnetlink dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * fix hwmon nil ptr (#2873) * fix hwmon nil ptr syslink maybe lost in some cases. --------- Signed-off-by: TaoGe <6657718+yowenter@users.noreply.github.com> * Fix hwmon error capture (#2915) Fix golangci-lint "ineffectual assignment" by correctly capturing any errors within the hwmon gathering loop. Signed-off-by: Ben Kochie <superq@gmail.com> * Update common Prometheus files (#2917) Signed-off-by: prombot <prometheus-team@googlegroups.com> * Revert "Add ZFS freebsd per dataset stats (#2753)" (#2925) This reverts commit f34aaa61092fe7e3c6618fdb0b0d16a68a291ff7. Signed-off-by: Caleb Webber <caleb@codingthemsoftly.com> * filesystem: fix mountTimeout not working issue (#2903) Signed-off-by: DongWei <jiangxuege@hotmail.com> * Fix description for NodeDiskIOSaturation alert (#2929) NodeDiskIOSaturation description should say 30m per the "for" clause Signed-off-by: Taylor Sly <slyt@users.noreply.github.com> * Enforce no subprocess policy (#2926) Add depguard to golangci-lint to enforce the no-os/exec policy. Signed-off-by: Ben Kochie <superq@gmail.com> * filesystem: surface device errors (#2923) filesystem: surface filesystem device error Fixes: #2918 --------- Signed-off-by: Pamela Mei i540369 <pamela.mei@sap.com> * Revert "filesystem: fix mountTimeout not working issue (#2903)" (#2932) This reverts commit 9f1f791ac2e1377781c4f8807a23d86d92ad6499. Signed-off-by: Ben Kochie <superq@gmail.com> * Update common Prometheus files (#2939) Signed-off-by: prombot <prometheus-team@googlegroups.com> * UPDATE base image golang version * UPDATE vulnerabilities dependencies * UPDATE dependencies --------- Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: dependabot[bot] <support@github.com> Sign…

Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>

Add an optional flag to set the RAPL zone as a label, instead of as part of the metric name. Fixes: prometheus#2299 Signed-off-by: Ben Kochie <superq@gmail.com>

* [CHANGE] Merge metrics descriptions in textfile collector prometheus#2475 * [FEATURE] [node-mixin] Add darwin dashboard to mixin prometheus#2351 * [FEATURE] Add "isolated" metric on cpu collector on linux prometheus#2251 * [FEATURE] Add cgroup summary collector prometheus#2408 * [FEATURE] Add selinux collector prometheus#2205 * [FEATURE] Add slab info collector prometheus#2376 * [FEATURE] Add sysctl collector prometheus#2425 * [FEATURE] Also track the CPU Spin time for OpenBSD systems prometheus#1971 * [FEATURE] Add support for MacOS version prometheus#2471 * [ENHANCEMENT] [node-mixin] Add missing selectors prometheus#2426 * [ENHANCEMENT] [node-mixin] Change current datasource to grafana's default prometheus#2281 * [ENHANCEMENT] [node-mixin] Change disk graph to disk table prometheus#2364 * [ENHANCEMENT] [node-mixin] Change io time units to %util prometheus#2375 * [ENHANCEMENT] Ad user_wired_bytes and laundry_bytes on *bsd prometheus#2266 * [ENHANCEMENT] Add additional vm_stat memory metrics for darwin prometheus#2240 * [ENHANCEMENT] Add device filter flags to arp collector prometheus#2254 * [ENHANCEMENT] Add diskstats include and exclude device flags prometheus#2417 * [ENHANCEMENT] Add node_softirqs_total metric prometheus#2221 * [ENHANCEMENT] Add rapl zone name label option prometheus#2401 * [ENHANCEMENT] Add slabinfo collector prometheus#1799 * [ENHANCEMENT] Allow user to select port on NTP server to query prometheus#2270 * [ENHANCEMENT] collector/diskstats: Add labels and metrics from udev prometheus#2404 * [ENHANCEMENT] Enable builds against older macOS SDK prometheus#2327 * [ENHANCEMENT] qdisk-linux: Add exclude and include flags for interface name prometheus#2432 * [ENHANCEMENT] systemd: Expose systemd minor version prometheus#2282 * [ENHANCEMENT] Use netlink for tcpstat collector prometheus#2322 * [ENHANCEMENT] Use netlink to get netdev stats prometheus#2074 * [ENHANCEMENT] Add additional perf counters for stalled frontend/backend cycles prometheus#2191 * [ENHANCEMENT] Add btrfs device error stats prometheus#2193 * [BUGFIX] [node-mixin] Fix fsSpaceAvailableCriticalThreshold and fsSpaceAvailableWarning prometheus#2352 * [BUGFIX] Fix concurrency issue in ethtool collector prometheus#2289 * [BUGFIX] Fix concurrency issue in netdev collector prometheus#2267 * [BUGFIX] Fix diskstat reads and write metrics for disks with different sector sizes prometheus#2311 * [BUGFIX] Fix iostat on macos broken by deprecation warning prometheus#2292 * [BUGFIX] Fix NodeFileDescriptorLimit alerts prometheus#2340 * [BUGFIX] Sanitize rapl zone names prometheus#2299 * [BUGFIX] Add file descriptor close safely in test prometheus#2447 * [BUGFIX] Fix race condition in os_release.go prometheus#2454 * [BUGFIX] Skip ZFS IO metrics if their paths are missing prometheus#2451 Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com>

Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>

Add an optional flag to set the RAPL zone as a label, instead of as part of the metric name. Fixes: prometheus#2299 Signed-off-by: Ben Kochie <superq@gmail.com>

* [CHANGE] Merge metrics descriptions in textfile collector prometheus#2475 * [FEATURE] [node-mixin] Add darwin dashboard to mixin prometheus#2351 * [FEATURE] Add "isolated" metric on cpu collector on linux prometheus#2251 * [FEATURE] Add cgroup summary collector prometheus#2408 * [FEATURE] Add selinux collector prometheus#2205 * [FEATURE] Add slab info collector prometheus#2376 * [FEATURE] Add sysctl collector prometheus#2425 * [FEATURE] Also track the CPU Spin time for OpenBSD systems prometheus#1971 * [FEATURE] Add support for MacOS version prometheus#2471 * [ENHANCEMENT] [node-mixin] Add missing selectors prometheus#2426 * [ENHANCEMENT] [node-mixin] Change current datasource to grafana's default prometheus#2281 * [ENHANCEMENT] [node-mixin] Change disk graph to disk table prometheus#2364 * [ENHANCEMENT] [node-mixin] Change io time units to %util prometheus#2375 * [ENHANCEMENT] Ad user_wired_bytes and laundry_bytes on *bsd prometheus#2266 * [ENHANCEMENT] Add additional vm_stat memory metrics for darwin prometheus#2240 * [ENHANCEMENT] Add device filter flags to arp collector prometheus#2254 * [ENHANCEMENT] Add diskstats include and exclude device flags prometheus#2417 * [ENHANCEMENT] Add node_softirqs_total metric prometheus#2221 * [ENHANCEMENT] Add rapl zone name label option prometheus#2401 * [ENHANCEMENT] Add slabinfo collector prometheus#1799 * [ENHANCEMENT] Allow user to select port on NTP server to query prometheus#2270 * [ENHANCEMENT] collector/diskstats: Add labels and metrics from udev prometheus#2404 * [ENHANCEMENT] Enable builds against older macOS SDK prometheus#2327 * [ENHANCEMENT] qdisk-linux: Add exclude and include flags for interface name prometheus#2432 * [ENHANCEMENT] systemd: Expose systemd minor version prometheus#2282 * [ENHANCEMENT] Use netlink for tcpstat collector prometheus#2322 * [ENHANCEMENT] Use netlink to get netdev stats prometheus#2074 * [ENHANCEMENT] Add additional perf counters for stalled frontend/backend cycles prometheus#2191 * [ENHANCEMENT] Add btrfs device error stats prometheus#2193 * [BUGFIX] [node-mixin] Fix fsSpaceAvailableCriticalThreshold and fsSpaceAvailableWarning prometheus#2352 * [BUGFIX] Fix concurrency issue in ethtool collector prometheus#2289 * [BUGFIX] Fix concurrency issue in netdev collector prometheus#2267 * [BUGFIX] Fix diskstat reads and write metrics for disks with different sector sizes prometheus#2311 * [BUGFIX] Fix iostat on macos broken by deprecation warning prometheus#2292 * [BUGFIX] Fix NodeFileDescriptorLimit alerts prometheus#2340 * [BUGFIX] Sanitize rapl zone names prometheus#2299 * [BUGFIX] Add file descriptor close safely in test prometheus#2447 * [BUGFIX] Fix race condition in os_release.go prometheus#2454 * [BUGFIX] Skip ZFS IO metrics if their paths are missing prometheus#2451 Signed-off-by: Ben Kochie <superq@gmail.com> Signed-off-by: Ben Kochie <superq@gmail.com>

discordianfish added accepted bug good first issue help wanted labels Mar 1, 2022

sourikghosh mentioned this issue Mar 1, 2022

sanitize rapl zone name #2301

Closed

aneagoe added a commit to aneagoe/node_exporter that referenced this issue May 9, 2022

rapl_collector: fix issue with invalid metric name (prometheus#2299)

0e320e7

Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>

aneagoe mentioned this issue May 9, 2022

rapl_collector: fix issue with invalid metric name (#2299) #2372

Merged

SuperQ closed this as completed in #2372 May 31, 2022

SuperQ added a commit that referenced this issue May 31, 2022

Merge pull request #2372 from aneagoe/master

e22382c

rapl_collector: fix issue with invalid metric name (#2299)

SuperQ reopened this May 31, 2022

SuperQ mentioned this issue Jun 13, 2022

Add rapl zone label option #2401

Merged

SuperQ added a commit that referenced this issue Jun 13, 2022

Add rapl zone label option

fa3a6bb

Add an optional flag to set the RAPL zone as a label, instead of as part of the metric name. Fixes: #2299 Signed-off-by: Ben Kochie <superq@gmail.com>

SuperQ added a commit that referenced this issue Jun 27, 2022

Add rapl zone label option

8425805

Add an optional flag to set the RAPL zone as a label, instead of as part of the metric name. Fixes: #2299 Signed-off-by: Ben Kochie <superq@gmail.com>

SuperQ closed this as completed in #2401 Jun 27, 2022

SuperQ added a commit that referenced this issue Jun 27, 2022

Add rapl zone label option (#2401)

d2b8ee8

Add an optional flag to set the RAPL zone as a label, instead of as part of the metric name. Fixes: #2299 Signed-off-by: Ben Kochie <superq@gmail.com>

SuperQ mentioned this issue Jul 9, 2022

GetRaplZones fails with zone names of the form package-N-die-M prometheus/procfs#459

Closed

tomhughes added a commit to openstreetmap/prometheus-exporters that referenced this issue Jul 9, 2022

Add patched build of node_exporter 1.3.1 with upstream fix

d557d34

prometheus/node_exporter#2299

raptorsun pushed a commit to raptorsun/node_exporter that referenced this issue Sep 12, 2022

rapl_collector: fix issue with invalid metric name (prometheus#2299)

febfdd5

Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>

SuperQ mentioned this issue Sep 24, 2022

Release 1.4.0 #2478

Merged

priteau added a commit to stackhpc/stackhpc-kayobe-config that referenced this issue Feb 28, 2023

Bump node exporter to 1.5.0

acea265

This fixes a crash seen on HPE DL385 nodes [1]: panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name [1] prometheus/node_exporter#2299

priteau mentioned this issue Feb 28, 2023

Bump node exporter to 1.5.0 stackhpc/stackhpc-kayobe-config#412

Merged

priteau added a commit to stackhpc/stackhpc-kayobe-config that referenced this issue Mar 15, 2023

Bump node exporter to 1.5.0

edf5c1a

This fixes a crash seen on HPE DL385 nodes [1]: panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name [1] prometheus/node_exporter#2299

oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this issue Apr 9, 2024

rapl_collector: fix issue with invalid metric name (prometheus#2299)

669f26d

Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>

oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this issue Apr 9, 2024

rapl_collector: fix issue with invalid metric name (prometheus#2299)

9d211e9

Signed-off-by: Andrei Neagoe <3854672+aneagoe@users.noreply.github.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

rapl collector crash: panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name #2299

rapl collector crash: panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name #2299

baryluk commented Mar 1, 2022

discordianfish commented Mar 1, 2022

baryluk commented Mar 1, 2022 via email

alanorth commented May 19, 2022

SuperQ commented May 31, 2022

stephankoelle commented Jun 8, 2022

jardaKalus commented Jun 13, 2022

aneagoe commented Jun 17, 2022

rapl collector crash: panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name #2299

rapl collector crash: panic: "node_rapl_package-0-die-0_joules_total" is not a valid metric name #2299

Comments

baryluk commented Mar 1, 2022

Host operating system: output of uname -a

node_exporter version: output of node_exporter --version

node_exporter command line flags

Are you running node_exporter in Docker?

What did you do that produced an error?

discordianfish commented Mar 1, 2022

baryluk commented Mar 1, 2022 via email

alanorth commented May 19, 2022

SuperQ commented May 31, 2022

stephankoelle commented Jun 8, 2022

jardaKalus commented Jun 13, 2022

aneagoe commented Jun 17, 2022

Host operating system: output of `uname -a`

node_exporter version: output of `node_exporter --version`