Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bcache: add bdev/writeback_rate_debug stats #277

Merged
merged 8 commits into from
Apr 30, 2020

Conversation

AlexZzz
Copy link
Contributor

@AlexZzz AlexZzz commented Mar 31, 2020

Hi! This PR adds support for bache writeback_rate_debug stats.
It's called debug, but it has useful information. It shows current writeback rate, target size of dirty data and PI-controller values. It is very usefull for debugging and helps to make decision to tweak bcache's PI-controller.
@pgier @discordianfish , could you approve this?

AlexZzz added 7 commits March 31, 2020 14:56
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
@AlexZzz AlexZzz force-pushed the bcache_writeback_debug branch from cbf920d to 68ac0f3 Compare March 31, 2020 15:07
Signed-off-by: Aleksei Zakharov <zaharov@selectel.ru>
@discordianfish
Copy link
Member

@pgier @SuperQ

Copy link
Collaborator

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pgier pgier merged commit e12f038 into prometheus:master Apr 30, 2020
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
Bcache: add bdev/writeback_rate_debug stats
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants