Fix for mountstats error due to multiline "impl_id" on FreeNAS #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an error happening when trying to parse data from FreeNAS NFS mount point. "impl_id" is printed in multiple lines, which triggers "not enough information for NFS stats" error. Signed-off-by: Jakub Wesolowski <jakubwesolowski@posteo.net>
|
Can you create a new test case with the (obfuscated) content of /proc/self/mountstats you see? |
Signed-off-by: Jakub Wesolowski <jakubwesolowski@posteo.net>
|
Sure. |
remijouannet
pushed a commit
to remijouannet/procfs
that referenced
this pull request
Oct 20, 2022
…theus#339) * Fix for mountstats error due to multiline "impl_id" on FreeNAS This commit fixes an error happening when trying to parse data from FreeNAS NFS mount point. "impl_id" is printed in multiple lines, which triggers "not enough information for NFS stats" error. Signed-off-by: Jakub Wesolowski <jakubwesolowski@posteo.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue described in prometheus/node_exporter#1583
When reading from /proc/self/mountstats for FreeNAS NFS mount, the data in "impl_id" tends to be printed in 3 lines. As seen in the above issue, the second and third line are one field long. This results in parser exiting with "not enough information for NFS stats" error.
The PR moves the length check so that node-exporter won't crash when trying to export NFS client metrics connected to the FreeNAS server.
@discordianfish @pgier