Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix null pointer return in net_udp #355

Merged
merged 2 commits into from
Feb 8, 2021
Merged

Fix null pointer return in net_udp #355

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0056c99
fix crash seen in node_exporter
hubt Feb 7, 2021
573081e
return err isntead of nil
hubt Feb 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions net_udp.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,17 +38,13 @@ func (fs FS) NetUDP6() (NetUDP, error) {
// NetUDPSummary returns already computed statistics like the total queue lengths
// for UDP datagrams read from /proc/net/udp.
func (fs FS) NetUDPSummary() (*NetUDPSummary, error) {
n, err := newNetUDPSummary(fs.proc.Path("net/udp"))
n1 := NetUDPSummary(*n)
return &n1, err
return newNetUDPSummary(fs.proc.Path("net/udp"))
}

// NetUDP6Summary returns already computed statistics like the total queue lengths
// for UDP datagrams read from /proc/net/udp6.
func (fs FS) NetUDP6Summary() (*NetUDPSummary, error) {
n, err := newNetUDPSummary(fs.proc.Path("net/udp6"))
n1 := NetUDPSummary(*n)
return &n1, err
return newNetUDPSummary(fs.proc.Path("net/udp6"))
}

// newNetUDP creates a new NetUDP{,6} from the contents of the given file.
Expand Down