Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing godoc comments for xfrm stats #433

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

tklauser
Copy link
Contributor

Add missing godoc comments matching the kernel documentation, see
https://www.kernel.org/doc/html/latest/networking/xfrm_proc.html

Also rename the xfrm*.go files to have a net_ prefix, as the
respective file is found in the net/ sub-directory and this matches
filenames for other network-related stats.

Add missing godoc comments matching the kernel documentation, see
https://www.kernel.org/doc/html/latest/networking/xfrm_proc.html

Also rename the `xfrm*.go` files to have a `net_` prefix, as the
respective file is found in the `net/` sub-directory and this matches
filenames for other network-related stats.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Copy link
Member

@discordianfish discordianfish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ merged commit 5f46783 into prometheus:master Jan 26, 2022
@tklauser tklauser deleted the xfrm-stats-godoc branch January 26, 2022 11:56
remijouannet pushed a commit to remijouannet/procfs that referenced this pull request Oct 20, 2022
Add missing godoc comments matching the kernel documentation, see
https://www.kernel.org/doc/html/latest/networking/xfrm_proc.html

Also rename the `xfrm*.go` files to have a `net_` prefix, as the
respective file is found in the `net/` sub-directory and this matches
filenames for other network-related stats.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
jritter pushed a commit to jritter/procfs that referenced this pull request Jul 15, 2024
Add missing godoc comments matching the kernel documentation, see
https://www.kernel.org/doc/html/latest/networking/xfrm_proc.html

Also rename the `xfrm*.go` files to have a `net_` prefix, as the
respective file is found in the `net/` sub-directory and this matches
filenames for other network-related stats.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants