-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce parsing for /proc/<pid>/net/snmp
, /proc/<pid>/net/snmp6
and /proc/<pid>/net/netstat
.
#435
Conversation
6f39a9c
to
a8481ba
Compare
Nice, do we have to worry about missing fields in various kernel versions? We like to be able to support very old kernels in this library, since Go will run on kernels as old as 2.6.23. |
Any chance I can also get you to implement |
Sure i will implement snmp6 and netstat also. |
/proc/<pid>/net/snmp
./proc/<pid>/net/snmp
, /proc/<pid>/net/snmp6
and /proc/<pid>/net/netstat
.
a8481ba
to
c0cd365
Compare
@SuperQ I added also snmp6 and netstat. Have a look please! |
c0cd365
to
978dee6
Compare
… and `/proc/<pid>/net/netstat`. Signed-off-by: Nikos Kakavas <nikakis@protonmail.com>
978dee6
to
3d753b0
Compare
Signed-off-by: Nikos Kakavas <nikakis@protonmail.com>
dc5e963
to
5c12586
Compare
@discordianfish @SuperQ Have a look again please! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, LGTM!
Hello! @discordianfish @SuperQ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just had a couple of optional in-line suggestions.
99e9c79
to
18c4ef8
Compare
Signed-off-by: Nikos Kakavas <nikakis@protonmail.com>
18c4ef8
to
6ff7304
Compare
// and returns a map contains those metrics. | ||
func parseSNMP6Stats(r io.Reader) (ProcSnmp6, error) { | ||
var ( | ||
scanner = bufio.NewScanner(r) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will fix this fmt issue and also try to investigate why this didn't worked properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird. Maybe out of date source branch?
…snmp Introduce parsing for `/proc/<pid>/net/snmp`, `/proc/<pid>/net/snmp6` and `/proc/<pid>/net/netstat`.
No description provided.