Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump max buffer size to 1024kb to handle larger mountinfo files #458

Merged
merged 1 commit into from
Jun 21, 2022
Merged

Bump max buffer size to 1024kb to handle larger mountinfo files #458

merged 1 commit into from
Jun 21, 2022

Conversation

anguswilliams
Copy link
Contributor

@anguswilliams anguswilliams commented Jun 20, 2022 •
edited by SuperQ
Loading

Closes #457

@anguswilliams
Bump max buffer size to 1024kb to handle larger mountinfo files
08d83cd 
Signed-off-by: anguswilliams <anguswilliams@gmail.com>
SuperQ
SuperQ approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pgier
pgier approved these changes Jun 21, 2022
View reviewed changes
Copy link
Collaborator

@pgier pgier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgier pgier merged commit f74c35e into prometheus:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperQ SuperQ SuperQ approved these changes

@pgier pgier pgier approved these changes

@discordianfish discordianfish Awaiting requested review from discordianfish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ReadFileNoStat causes issues collecting mountinfo with high number of mounts
3 participants
@anguswilliams @pgier @SuperQ