Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create new error types in proc.go and use them to unify error messages #526

Merged
merged 1 commit into from
May 23, 2023
Merged

Create new error types in proc.go and use them to unify error messages #526

merged 1 commit into from
May 23, 2023

Conversation

conallob
Copy link
Contributor

@conallob conallob commented May 23, 2023 •
edited
Loading

Start using new errors to unify error messages, complete with groundwork for wrapping errors once Go v1.20+ is the default

This implements #358

@conallob
Create new errors in proc.go using errors module.
5837388 
Start using new errors to unify error messages, complete with groundwork for
wrapping errors once Go v1.20+ is the default

Signed-off-by: Conall O'Brien <conall@conall.net>
@conallob conallob mentioned this pull request May 23, 2023
Closed
@conallob
Copy link
Contributor Author

#519 already exists to track wrapping errors, once Go v1.20 is the default version

@SuperQ SuperQ merged commit 6a7bbcc into prometheus:master May 23, 2023
@conallob conallob mentioned this pull request Nov 28, 2023
Closed
jritter pushed a commit to jritter/procfs that referenced this pull request Jul 15, 2024
@conallob @jritter
Create new errors in proc.go using errors module. (prometheus#526)
517b207 
Start using new errors to unify error messages, complete with groundwork for
wrapping errors once Go v1.20+ is the default

Signed-off-by: Conall O'Brien <conall@conall.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@discordianfish discordianfish discordianfish approved these changes

@SuperQ SuperQ SuperQ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@conallob @discordianfish @SuperQ