-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document feature flag 'created-timestamp-zero-ingestion' #13279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Some suggestions 💪🏽
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, last nit! Thanks.
docs/feature_flags.md
Outdated
|
||
`--enable-feature=created-timestamp-zero-ingestion` | ||
|
||
Enables ingestion of created timestamps as a injection of samples with 0 value for created timestamp (when appropriate). See PromCon talk <https://youtu.be/nWf0BfQ5EEA?feature=shared> for details on the created timestamp. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Enables ingestion of created timestamps as a injection of samples with 0 value for created timestamp (when appropriate). See PromCon talk <https://youtu.be/nWf0BfQ5EEA?feature=shared> for details on the created timestamp. | |
Enables ingestion of created timestamp. Created timestamps are injected as 0 valued samples when appropriate. See [PromCon talk](https://youtu.be/nWf0BfQ5EEA) for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't treat my suggestions literally @ArthurSens (: <Link>
was just semantically what would be nice, not literal structure of link in markdown (:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, for some reason I thought you were saying that this is how links are shown in the website 😅
Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
…13279) Signed-off-by: Arthur Silva Sens <arthur.sens@coralogix.com>
Documenting the feature flag added in #12733