Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubernetes SD: Add node name and host IP to pod discovery #1835

Merged
merged 1 commit into from
Jul 26, 2016

Conversation

jimmidyson
Copy link
Contributor

Fixes #1604

/cc @pdbogen @fabxc

@jimmidyson jimmidyson mentioned this pull request Jul 21, 2016
@fabxc
Copy link
Contributor

fabxc commented Jul 26, 2016

This won't collide with any potential plans for pod live-migration or anything?

@jimmidyson
Copy link
Contributor Author

Not that I can think of. Can you?

@fabxc
Copy link
Contributor

fabxc commented Jul 26, 2016

I'm not involved enough to know whether there are such plans. But if live migration will become a thing the node label would change and no longer be static for the target.

@brian-brazil
Copy link
Contributor

This is not the only thing that could potentially be dynamic among our SD mechanisms. As long as it being static is plausible then that's fine.

@jimmidyson
Copy link
Contributor Author

All I can find with a quick search on pod migration is a really old issue (kubernetes/kubernetes#3949) that has had no progress. There are various other issues but in similar state & lining back to that issue.

@jimmidyson
Copy link
Contributor Author

For now I expect it can be considered static.

@fabxc
Copy link
Contributor

fabxc commented Jul 26, 2016

Okay, thanks 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants