Add atan2 binop support (#117)

Signed-off-by: Julius Volz <julius.volz@gmail.com>
prometheus · Aug 9, 2023 · 0d65c96 · 0d65c96
1 parent 652e9c1
commit 0d65c96
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 1 deletion.
diff --git a/app/src/PromLens/NodeVisualizer/ExplainViews/BinaryExpr/computeBinop.ts b/app/src/PromLens/NodeVisualizer/ExplainViews/BinaryExpr/computeBinop.ts
@@ -26,6 +26,8 @@ export const scalarBinOp = (op: binaryOperatorType, lhs: number, rhs: number): n
  return Number(lhs >= rhs);
  case '<=':
  return Number(lhs <= rhs);
+ case 'atan2':
+ return Math.atan2(lhs, rhs);
  default:
  throw new Error('invalid binop');
  }
@@ -57,6 +59,8 @@ export const vectorElemBinop = (op: binaryOperatorType, lhs: number, rhs: number
  return { value: lhs, keep: lhs >= rhs };
  case '<=':
  return { value: lhs, keep: lhs <= rhs };
+ case 'atan2':
+ return { value: Math.atan2(lhs, rhs), keep: true };
  default:
  throw new Error('invalid binop');
  }

diff --git a/app/src/promql/ast.ts b/app/src/promql/ast.ts
@@ -43,6 +43,7 @@ export enum binaryOperatorType {
  and = 'and',
  or = 'or',
  unless = 'unless',
+ atan2 = 'atan2',
 }
 
 export const compOperatorTypes: binaryOperatorType[] = [

diff --git a/app/src/promql/format.tsx b/app/src/promql/format.tsx
@@ -214,7 +214,7 @@ const formatNodeInternal = (node: ASTNode, showChildren: boolean, maxDepth?: num
  return (
  <>
  {showChildren && formatNode(maybeParenthesizeBinopChild(node.op, node.lhs), showChildren, childMaxDepth)}{' '}
- {['and', 'or', 'unless'].includes(node.op) ? (
+ {['atan2', 'and', 'or', 'unless'].includes(node.op) ? (
  <span className="promql-keyword">{node.op}</span>
  ) : (
  <span className="promql-operator">{node.op}</span>

diff --git a/app/src/promql/utils.ts b/app/src/promql/utils.ts
@@ -31,6 +31,7 @@ const binOpPrecedence = {
  [binaryOperatorType.and]: 5,
  [binaryOperatorType.or]: 6,
  [binaryOperatorType.unless]: 5,
+ [binaryOperatorType.atan2]: 2,
 };
 
 export const maybeParenthesizeBinopChild = (op: binaryOperatorType, child: ASTNode): ASTNode => {