Update/remove various npm dependencies to fix syntax highlighting #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Volz <julius.volz@gmail.com>
Yeah that's fine. A code cleanup is necessary anyway I think. I just need to find the time for that 😅 |
|
Just for the record, after merging this PR, launching unit test won't be possible anymore. I'm not sure if there is one or if they are working. And I'm fine with that. |
Nexucis
approved these changes
Nov 10, 2022
|
Yup! Eventually it would be great to bring both the Cypress tests back and also add normal unit tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Nexucis These are just the fixes we paired on. Still doing the
error as Errorthing for now, but oh well...Signed-off-by: Julius Volz julius.volz@gmail.com