Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add postgres as a db #59

Merged
merged 4 commits into from
Nov 17, 2022
Merged

Add postgres as a db #59

merged 4 commits into from
Nov 17, 2022

Conversation

evkuzin
Copy link
Contributor

@evkuzin evkuzin commented Nov 17, 2022

github.com/lib/pq is in maintenance mode, but it seems like the best candidate still because we don't need all these fancy features that pgx provides and its fits as a database/sql Interface. Basically, I chose it based on this

Evgeny Kuzin added 2 commits November 17, 2022 14:51
Signed-off-by: Evgeny Kuzin <evgeny@hudson-trading.com>
DCO
Signed-off-by: Evgeny Kuzin <evgeny@hudson-trading.com>
Copy link
Member

@juliusv juliusv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you! Would you be ok with helping to look at any issues that users report with Postgres in the near future, if we add this?

pkg/sharer/sharer.go Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@evkuzin
Copy link
Contributor Author

evkuzin commented Nov 17, 2022

Awesome, thank you! Would you be ok with helping to look at any issues that users report with Postgres in the near future, if we add this?

Would be glad to :)

Signed-off-by: Evgeny Kuzin <evgeny@hudson-trading.com>
Signed-off-by: Evgeny Kuzin <evgeny@hudson-trading.com>
@juliusv
Copy link
Member

juliusv commented Nov 17, 2022

👍 Wonderful, thank you :)

@juliusv juliusv merged commit d7c6abb into prometheus:main Nov 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants