Permit comma-separated list of module names in "module" parameter #949
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept patch for discussion and review.
It allows a single scrape to specify a comma-separated list of modules, e.g.
module=if_mib,mikrotik
. This implements #731, and supports the breaking up of snmp.yml into independent MIB pieces as discussed in #938.Points to note/discuss (some marked TODO in source):
module=foo,bar
is supported. I could addmodule=foo&module=bar
as an additional option; however, I want to keep the former, because target rewriting rules can only specify a single instance of a given parameter (i.e.__param_module
in this case)module=if_mib,if_mib
), nor to handle distinct modules which generate overlapping metrics. In those cases, the Prometheus client library itself will barf, with an error like