Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initFromString should allow comments in config strings #67

Closed
shortdudey123 opened this issue Mar 22, 2017 · 3 comments
Closed

initFromString should allow comments in config strings #67

shortdudey123 opened this issue Mar 22, 2017 · 3 comments

Comments

@shortdudey123
Copy link

Problem
It appears that the initFromFile for the mapping config file is only read and then passed to initFromString. That method does not appear to have any way to handle comments in the string (or in this specific thought, the mapping file)

Possible Solution
Support golang style (//) comments in the initFromString and ignore them in the case statement in the if statement

@drawks
Copy link
Contributor

drawks commented Aug 1, 2017

Once yaml config files from #66 are merged it seems like the legacy mapper/config format could/should be put out to pasture. yaml allows for comments among many other improvements in how the data is structured.

I've been writing PRs against the branch in #66 for a few days and it is a big improvement.

@drawks
Copy link
Contributor

drawks commented Oct 2, 2017

#98 resolves this issue by dropping support for legacy style mapper configs in favor of the yaml configs from #66 which support comments.

@grobie
Copy link
Member

grobie commented Oct 4, 2017

Thanks!

@grobie grobie closed this as completed Oct 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants