Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes support for legacy mapper config #98

Merged
merged 1 commit into from
Sep 29, 2017

Conversation

drawks
Copy link
Contributor

@drawks drawks commented Sep 28, 2017

As discussed in #77 dropping legacy support reduces the code complexity in favor of the newer yaml config

  • Removed legacy mapper config parser
  • Removed logic to switch to YAML parsing based on mapping filename
  • Removed tests for legacy mapper config
  • Remove references to legacy mapper config format from README.md

  * Removed legacy mapper config parser
  * Removed logic to switch to YAML parsing based on mapping filename
  * Removed tests for legacy mapper config
  * Remove references to legacy mapper config format from `README.md`
Copy link
Member

@grobie grobie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ SuperQ merged commit 9accf49 into prometheus:master Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants