Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow for setting "#help" text in mapping config #78

Closed
drawks opened this issue Aug 1, 2017 · 3 comments
Closed

Allow for setting "#help" text in mapping config #78

drawks opened this issue Aug 1, 2017 · 3 comments
Labels
enhancement

Comments

@drawks
Copy link
Contributor

drawks commented Aug 1, 2017 •
edited
Loading

The current behavior of providing a help text like
# HELP test_case_total Metric autogenerated by statsd_exporter.

falls pretty far short of the intent of informing the consumer of the metric what the metric represents in easy language. This should be a very small modification that would improve usability.
@grobie
Copy link
Member

grobie commented Aug 1, 2017

Sounds good! Wanna give it a try and send a PR?

@drawks
Copy link
Contributor Author

drawks commented Aug 1, 2017

Yeah, I'll PR it once #66 is merged, I'd rather let the old mapper configuration format die on the vine and add new mapper features to yaml mapper config

drawks pushed a commit to drawks/statsd_exporter that referenced this issue Aug 3, 2017
Resolves prometheus#78 Allow help text to be customized
08da785 
  * Updated mappings to accept custom help text in YAML config
  * Updated exporter to display configured help messages
  * Update README to reflect aditional configurability
drawks pushed a commit to drawks/statsd_exporter that referenced this issue Aug 3, 2017
Resolves prometheus#78 Allow help text to be customized
259171b 
  * Updated mappings to accept custom help text in YAML config
  * Updated exporter to display configured help messages
  * Update README to reflect aditional configurability
  * Minor Update to exporter to allow tests to pass with mocked
    statsdlistener that has no mappers
drawks pushed a commit to drawks/statsd_exporter that referenced this issue Oct 2, 2017
Resolves prometheus#78 Allow help text to be customized
72e48c9 
  * Updated mappings to accept custom help text in YAML config
  * Updated exporter to display configured help messages
  * Update README to reflect aditional configurability
  * Minor Update to exporter to allow tests to pass with mocked
    statsdlistener that has no mappers
@drawks
Copy link
Contributor Author

drawks commented Oct 6, 2017

This issue is resolved in #87

@drawks drawks closed this as completed Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@grobie @drawks