Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix (tmp) for prometheus-builder:master causing npm install freeze on prombench runs. #833

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

bwplotka
Copy link
Member

@bwplotka bwplotka commented Feb 7, 2025

This custom image is locally build from prometheus/golang-builder#296 that we agree to pause until Prometheus release. However, Prometheus release needs working prombench. This is a tmp solution until we have an official image.

Mitigates #832

…ch runs

This custom image is locally build from prometheus/golang-builder#296
that we agree to pause until Prometheus release. However, Prometheus release
needs working prombench. This is a tmp solution until we have an official image.

Mitigates #832

Signed-off-by: bwplotka <bwplotka@gmail.com>
Copy link
Member

@Nexucis Nexucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thank you for doing that @bwplotka !
Hope it will unlock the situation

bwplotka added a commit that referenced this pull request Feb 7, 2025
Signed-off-by: bwplotka <bwplotka@gmail.com>
@bwplotka
Copy link
Member Author

bwplotka commented Feb 7, 2025

@bwplotka bwplotka merged commit dd2ec1e into master Feb 7, 2025
4 checks passed
@bwplotka bwplotka deleted the incident-fix branch February 7, 2025 12:30
kushalShukla-web pushed a commit to kushalShukla-web/test-infra that referenced this pull request Feb 8, 2025
…ch runs (prometheus#833)

This custom image is locally build from prometheus/golang-builder#296
that we agree to pause until Prometheus release. However, Prometheus release
needs working prombench. This is a tmp solution until we have an official image.

Mitigates prometheus#832

Signed-off-by: bwplotka <bwplotka@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants