Only mention “public” in post status option if relevant.

[rvdsteege]

I found the post status setting options a bit overwhelming:

This PR changes the option to only denote "public" if that is the case for the post status:

[remcotolsma]

I have struggled with this notation for a while. The disadvantage of this proposal is that if there are only 'public' => false post statuses, so no public post statuses at all, the visibility remains a guess for users. I have also tried to shorten this with emojis or something, but that was not necessarily very clear either. That is how I eventually came up with this notation, it is not perfect, but I doubt whether this PR is an improvement. The backtics are also more of a markdown thing, should we use it like that? We need custom selects → https://developer.chrome.com/blog/rfc-customizable-select, https://open-ui.org/components/customizableselect/ 😏.

[rvdsteege]

Can we not use plain old <optgroup>? If there are no options for a group, the group can be omitted. If there are only options of a single group, the visibility is still mentioned/clear.

The backtics are also more of a markdown thing

I was somewhat hesitant to add them, but when both the post status and "public" were mentioned, I thought it needed some kind of distinction. However, the backticks are no longer needed with the optgroup and I've removed them in 63620a3.

[remcotolsma]

Nice solution, smart to use <optgroup> elements for this.

[remcotolsma]

I prefer to use https://www.php.net/array_filter so that there is no such logic in the foreach.

[rvdsteege]

Changed in 85d7052.