Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow latest release of reek, 6.0.0 #27

Merged
merged 2 commits into from
Jan 31, 2021
Merged

Allow latest release of reek, 6.0.0 #27

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89a758e
Upgrade to reek 6.0.0. Make test ignore reek version
anvox May 21, 2020
7c4ea4e
Merge pull request #1 from anvox/upgrade-reek-to-6
anvox May 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pronto-reek.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ Gem::Specification.new do |s|
s.require_paths = ['lib']

s.add_dependency('pronto', '~> 0.10.0')
s.add_dependency('reek', '>= 4.2', '< 6.0')
s.add_dependency('reek', '>= 4.2', '< 7.0')
s.add_development_dependency('rake', '~> 12.0')
s.add_development_dependency('rspec', '~> 3.4')
s.add_development_dependency('rspec-its', '~> 1.2')
Expand Down
8 changes: 4 additions & 4 deletions spec/pronto/reek_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ module Pronto

its(:count) { should == 2 }
its(:'first.msg') do
should ==
"Has the parameter name 'n' - [UncommunicativeParameterName](https://github.com/troessner/reek/blob/v5.6.0/docs/Uncommunicative-Parameter-Name.md)"
should \
match(/Has the parameter name 'n' - \[UncommunicativeParameterName\]\(https:\/\/github.com\/troessner\/reek\/blob\/v\d+\.\d+\.\d+\/docs\/Uncommunicative-Parameter-Name.md\)/)
end

its(:'last.msg') do
should ==
"Has the variable name '@n' - [UncommunicativeVariableName](https://github.com/troessner/reek/blob/v5.6.0/docs/Uncommunicative-Variable-Name.md)"
should \
match(/Has the variable name '@n' - \[UncommunicativeVariableName\]\(https:\/\/github.com\/troessner\/reek\/blob\/v\d+\.\d+\.\d+\/docs\/Uncommunicative-Variable-Name.md\)/)
end
end

Expand Down