Fix ${line} in text format to mean line number #270
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to reproduce:
Create a reasonable-sounding .pronto.yml that looks like this, based on documentation from https://github.com/prontolabs/pronto#message-format:
Run against a project
Expected results:
Receive text output that looks like this:
Observed results:
Notes:
Looks like the json_formatter.rb already looks for line number via the same method I'm proposing here. I'm guessing changing the meaning of
message.line
is a nonstarter given you'd have to change all of the runners at the same time, so using the decorator to adjust the meaning seemed like the right thing.